Re: [Cvs-cvs] ccvs/windows-NT ChangeLog config.h.in config.h

[Derek R. Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mark D. Baushke wrote:
> Hi Jim,
> 
> You need to fix windows-NT/config.h.in.in and regenerate config.h.in and
> config.h from that change. Otherwise, your change will get lost over and
> over again as we move forward.

Mark,

Wrong twice, I think.

If adding HAVE_NDIR_H were the right thing to do, Jim would need to
change windows-NT/config.h.in.footer.  windows-NT/config.h.in.in is
parsed, and keys that exist there and in the generated
windows-NT/config.h.in are replaced to generate windows-NT/config.h.
windows-NT/config.h.in.footer is placed verbatim at the end of the
generated windows-NT/config.h, so stuff that doesn't exist in
windows-NT/config.h.in needs to go there.

In this case, however, GNULIB started assuming <ndir.h> when
!HAVE_DIRENT_H, so the right thing for the rest of the code would be to
do the same, removing the need for HAVE_NDIR_H.

I'm installing this change.


Jim,

Please don't change the config.h.in files.  They are *both*
autogenerated.  The top level one is generated by autoconf from the
configure.in file.

I'm backing out your most recent change to the top level config.h.in.

Cheers,

Derek
- --
Derek R. Price
CVS Solutions Architect
Get CVS support at Ximbiot <http://ximbiot.com>!
v: +1 248.835.1260
f: +1 248.835.1263
<mailto:address@hidden>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFErlA8LD1OTBfyMaQRAoxoAKD5qWiIDlMB+KCUUJBa+L53V3FpuQCfbi/6
chJlEJvNOTKUDECDm2RpABI=
=6ozD
-----END PGP SIGNATURE-----