dazuko-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Dazuko-devel] patch 8 for dazukofs release 3.0.0


From: Lino Sanfilippo
Subject: [Dazuko-devel] patch 8 for dazukofs release 3.0.0
Date: Mon, 27 Apr 2009 12:42:44 +0200
User-agent: IceDove 1.5.0.14eol (X11/20090105)



Bug description:
If the underlaying filesystem does not implement one or more of the inode operations related to extended attributes(i.e. vfat), dazukofs returns an ENOSYS error code. This seems not to be the proper return value, since it results in ugly "function not implemented" messages on some systems, that use extended attributes related system calls (this happens for example on OpenSuse11.1 systems, every time that an "ls -l" command is executed within an dazukofs
that is mounted over vfat).
The error code set by the vfs layer is indeed -EOPNOTSUPP, if those functions are not implemented. So this patch replaces the ENOSYS with EOPNOTSUPP error codes to be conform to the
vfs behavior.

Geschäftsführender Gesellschafter: Tjark Auerbach
Sitz der Gesellschaft: Tettnang
Handelsregister: Amtsgericht Ulm, HRB 630992
ALLGEMEINE GESCHÄFTSBEDINGUNGEN
Es gelten unsere Allgemeinen Geschäftsbedingungen
(AGB). Sie finden sie in der jeweils gültigen Fassung
im Internet unter http://www.avira.de/agb
***************************************************
diff -rup dazukofs-3.0.0-p7/inode.c dazukofs-3.0.0-p8/inode.c
--- dazukofs-3.0.0-p7/inode.c   2009-04-21 14:37:12.000000000 +0200
+++ dazukofs-3.0.0-p8/inode.c   2009-04-27 11:37:07.000000000 +0200
@@ -511,7 +511,7 @@ static int dazukofs_setxattr(struct dent
 
        if (!lower_dentry_inode->i_op ||
            !lower_dentry_inode->i_op->setxattr) {
-               err = -ENOSYS;
+               err = -EOPNOTSUPP;
                goto out;
        }
 
@@ -543,7 +543,7 @@ static ssize_t dazukofs_getxattr(struct 
 
        if (!lower_dentry_inode->i_op ||
            !lower_dentry_inode->i_op->getxattr) {
-               err = -ENOSYS;
+               err = -EOPNOTSUPP;
                goto out;
        }
 
@@ -572,7 +572,7 @@ static ssize_t dazukofs_listxattr(struct
 
        if (!lower_dentry_inode->i_op ||
            !lower_dentry_inode->i_op->listxattr) {
-               err = -ENOSYS;
+               err = -EOPNOTSUPP;
                goto out;
        }
 
@@ -599,7 +599,7 @@ static int dazukofs_removexattr(struct d
 
        if (!lower_dentry_inode->i_op ||
            !lower_dentry_inode->i_op->removexattr) {
-               err = -ENOSYS;
+               err = -EOPNOTSUPP;
                goto out;
        }
 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]