Re: [Dazuko-devel] Patch 4/5

[John Ogness]

On 2010-07-08, Lino Sanfilippo <address@hidden> wrote:
> This patch fixes a missing cleanup in cases where an error occurs
> after an event has already been assigned to a group.  Before an
> event has not been put back to the "todo" list properly (the
> list_del() for the working list was missing) and also was not put
> back in cases of error in dazukofs_group_read().
>
> There is still something missing:
> If a filedescriptor has already been opened for an event, it has to
> be closed before it is put back to the "working list".  I will send
> a fix for this issue with another patch.

Thank you for pointing this out. The latest version (3.1.4-rc1) fixes
this issue and also handles closing the file descriptor. I chose not
to use your implementation because I felt it made the group use_count
handling too complicated.

John Ogness

-- 
Dazuko Maintainer