[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
rsh -n again
From: |
Dan Kegel |
Subject: |
rsh -n again |
Date: |
Fri, 25 Jul 2003 17:12:30 -0700 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030617 |
I recently submitted a patch to add the -n parameter to rsh
so that runtest wouldn't hang if you ran it in the background.
The feedback I got was "Nah, put the -n in $RSH if you need it."
Unfortunately, that won't work. In rsh_exec, dejagnu pipes
something into rsh via stdin, and -n would break that.
So I have a pretty good feeling that inserting -n's into the
rsh calls in dejagnu that don't redirect stdin is indeed
a good idea. Something like this:
--- dejagnu-1.4.3/lib/rsh.exp.old Mon Jun 30 16:23:50 2003
+++ dejagnu-1.4.3/lib/rsh.exp Mon Jun 30 16:28:00 2003
@@ -183,8 +183,8 @@
set desthost [board_info $desthost hostname];
}
- set status [catch "exec $RSH $rsh_useropts $desthost rm -f $destfile |&
cat" output]
+ set status [catch "exec $RSH -n $rsh_useropts $desthost rm -f $destfile |&
cat" output]
set status [catch "exec $RCP $srcfile $rcp_user$desthost:$destfile |& cat"
output]
if { $status == 0 } {
verbose "Copied $srcfile to $desthost:$destfile" 2
return $destfile;
except that you'd also want to fix remote.exp (which, for some
godforsaken reason, invokes $RSH directly itself).
- Dan
- rsh -n again,
Dan Kegel <=