RSH testing patch

[Daniel Jacobowitz]

If you set a username in board_info, you'll get syntax errors in
standard_spawn; it's been this way for as far back as I checked.
I've had something similar in a local tree for a while.

Oh, and spawn does not split arguments, so you can't use spawn
$rsh_useropts.  Eval would work of course but then you have to quote
commandline; this was easier.

2004-03-05  Daniel Jacobowitz  <address@hidden>

        * lib/remote.exp (standard_spawn): Fix rsh username support.

Index: lib/remote.exp
===================================================================
RCS file: /cvsroot/dejagnu/dejagnu/lib/remote.exp,v
retrieving revision 1.17
diff -u -p -r1.17 remote.exp
--- lib/remote.exp      7 Feb 2004 06:52:39 -0000       1.17
+++ lib/remote.exp      5 Mar 2004 22:14:47 -0000
@@ -1,5 +1,5 @@
 # Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000,
-# 2001, 2002, 2003 Free Software Foundation, Inc.
+# 2001, 2002, 2003, 2004 Free Software Foundation, Inc.
 #
 # This file is part of DejaGnu.
 #
@@ -860,19 +860,18 @@ proc standard_spawn { dest commandline }
         set RSH [board_info $dest rsh_prog]
     }
 
-    if ![board_info $dest exists username] {
-        set rsh_useropts ""
-    } else {
-        set rsh_useropts "-l $username"
-    }
-
     if [board_info $dest exists hostname] {
        set remote [board_info $dest hostname]
     } else {
        set remote $dest
     }
 
-    spawn $RSH $rsh_useropts $remote $commandline
+    if ![board_info $dest exists username] {
+        spawn $RSH $remote $commandline
+    } else {
+        spawn $RSH -l [board_info $dest username] $remote $commandline
+    }
+
     set board_info($dest,fileid) $spawn_id
     return $spawn_id
 }

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer