[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Few improvements for androideabi board
|
From: |
Rob Savoye |
|
Subject: |
Re: Few improvements for androideabi board |
|
Date: |
Mon, 14 Oct 2013 09:56:56 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/14/2013 04:14 AM, Ben Elliston wrote:
> Rob, would you mind reviewing this patch? You know this bit of code
> better than I do.
I'd like to see the 'iscross' proc removed, ! 'isnative' should be
sufficient. I'm a touch confused, this looks like you are also
supporting native builds on Android ? The -mandroid flag is the default
now if you configure with '*-androideabi', but explicitly using is
should be fine. I've not had to set execute permissions when I run
testsuites remotely on Android, so I'm curious why you do... I don't
have any Intel based Android syastem, is it different than the ARM based
platforms ?
The rest of the patch looks fine.
- rob -
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlJcFDgACgkQULmhEKC20/6qqACff79ZSSJByg6PpP7b/Qf7Ij4P
1IQAn2mI4KYue5eCJotDcEnd2YFTLLi0
=Uj6O
-----END PGP SIGNATURE-----