dejagnu
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Update .gitignore


From: Filipe Brandenburger
Subject: Re: [PATCH] Update .gitignore
Date: Fri, 15 May 2015 10:41:24 -0700

Hi Ben,

On Fri, May 15, 2015 at 3:28 AM, Ben Elliston <address@hidden> wrote:
> On Thu, May 14, 2015 at 11:43:21PM -0700, Filipe Brandenburger wrote:
>> Tested by running `./configure --enable-maintainer-mode' and then
>> the sequence `make && make check && make distcheck' and confirming
>> that the `git status' output did not show any untracked files.
>
> I don't like ignoring too much stuff with .gitignore.  The reason
> you're having this problem is that you're building in the source
> directory.  Don't Do That. :)  Use a separate build directory.

Ok, that's fair... but in that case, I think you would want to enforce
(or strongly suggest) it, so I sent you another patch set that uses
AX_ENABLE_BUILDDIR to store build artifacts on a build/ subdirectory
if an in-tree build is attempted.

Regardless of the solution you pick, I think keeping .gitignore up to
date is important to prevent mistakes when working with the git tree.

Let me know what you think.

Cheers,
Filipe



reply via email to

[Prev in Thread] Current Thread [Next in Thread]