Re: [Patch] Fix output pattern checking issue

[Ben Elliston]

On Fri, Mar 04, 2016 at 10:20:57PM +0100, Yvan Roux wrote:

> there is an issue when remote testing testcases which check an
> output pattern with an explicit '\n' at the end.  rsh_exec
> explicitly removes it to behave as 'exec', I don't know if something
> changed in 'exec' behavior since these lines were checked in in 2001
> or if it still removes a '\n' in some configs, but there is a
> mismatch between native, where these kind of tests are ok, and
> remote, where they fail.

Natively, exec strips the newline (and there are no occurrences of
"keenewline" in the source tree; I grepped).  Here's a simple test
script (foo.exp):

  set x [exec uptime]
  set x2 [rsh_exec remotebox uptime "" "" ""]

  note "local: >${x}<"
  note "remote:>[lindex $x2 1]<"

No newline in either case, which is what I would have expected.

Cheers, Ben

signature.asc
Description: Digital signature