Re: PATCH: rewrite utils.exp:which

[Rob Savoye]

On 03/21/2016 01:50 PM, Ben Elliston wrote:
> There was a '???' comment in utils.exp:which, so I rewrote it to
> properly mimic the behaviour of the which(1) shell utility.  A nice
> side effect of the new version is that, because the new proc
> normalises the filename when it's found, the GCC testsuite reports:
> 
>   /home/bje/build/gcc/gcc/xg++  version 6.0.0 20160310 (experimental) (GCC)
> 
> instead of:
> 
>   /home/bje/build/gcc/gcc/testsuite/g++/../../xg++  version 6.0.0 20160310 
> (experimental) (GCC)
> 
> Here's the patch. Tested with `make check' and a GCC testsuite run.
> Any comments?

  Was that testing done for a native build ? I can try it for cross
toolchains on my build farm for ARMv7/ARMv8 if so. The patch looks right
though, but a little paranoia goes a long way when it comes to toolchain
validation...

        - rob -