[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PATCH: add relative_file_name procedure to encapsulate logic for "su

From: Jacob Bachmeyer
Subject: Re: PATCH: add relative_file_name procedure to encapsulate logic for "subdir" variable [revised]
Date: Tue, 04 Dec 2018 00:55:01 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20090807 MultiZilla/ SeaMonkey/1.1.17 Mnenhy/

Ben Elliston wrote:
On Tue, Dec 04, 2018 at 12:10:53AM -0600, Jacob Bachmeyer wrote:
While the GNU Coding Standards suggest using "file name"
specifically; a quick grep shows that DejaGnu already has proc
unix_clean_filename and no procedures that use "file_name" in their
names, so consistency suggests that the change should be made.  A
revised patch follows.

Thanks. One more request: can you please document this new proc in the
NEWS file (along with --local/global_init)?

Here is a separate patch for the NEWS file:

diff --git a/NEWS b/NEWS
index cb8f01a..aed6a9b 100644
--- a/NEWS
+++ b/NEWS
@@ -5,6 +5,10 @@ Changes since 1.6.2:
1. The internal proc 'is_remote' has been renamed to 'isremote' for
   consistency with the other similar procs (eg, istarget). Testsuites
   should use this proc. The 'is_remote' proc is deprecated.
+2. runtest now accepts --local_init and --global_init options to override
+   the default of reading "site.exp".  See the manual for details.
+3. A utility procedure relative_filename has been added.  This procedure
+   computes a relative file name to a given destination from a given base.

Changes since 1.6.1:


-- Jacob

reply via email to

[Prev in Thread] Current Thread [Next in Thread]