[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PATCH: move processing of -V|--version to earlier point

From: Ben Elliston
Subject: Re: PATCH: move processing of -V|--version to earlier point
Date: Sun, 16 Dec 2018 16:21:17 +1100
User-agent: Mutt/1.9.4 (2018-02-28)

On Sat, Dec 15, 2018 at 11:04:58PM -0600, Jacob Bachmeyer wrote:

> This patch moves the processing for "runtest --version" to the first
> run through the command line arguments.  Since the presence of this
> option completely alters program flow, leading to an early exit
> rather than running tests, there is no reason to load the rest of
> the framework just to print version numbers from runtest.exp itself,
> the Expect extension, and the Tcl interpreter.

It also has the advantage of removing warnings such as:

WARNING: Couldn't find the global config file.

I see this speeds up runtest --version quite considerably, which is a
nice side effect. Thanks!


Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]