dejagnu
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PATCH: add dejagnu(1) multi-launcher


From: Jacob Bachmeyer
Subject: Re: PATCH: add dejagnu(1) multi-launcher
Date: Wed, 19 Dec 2018 18:04:32 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.22) Gecko/20090807 MultiZilla/1.8.3.4e SeaMonkey/1.1.17 Mnenhy/0.7.6.0

Andreas Schwab wrote:
On Dez 18 2018, Jacob Bachmeyer <address@hidden> wrote:
Andreas Schwab wrote:
On Dez 18 2018, Jacob Bachmeyer <address@hidden> wrote:
+if expr "$verbose" \> 0 > /dev/null ; then
Why not test $verbose -gt 0?
The existing "runtest" script uses expr for those tests.  I decided to
follow suit on the assumption that that choice was made for a reason,
presumably portability, although the Autoconf portable shell guidelines do
not mention that concern with "test".

Your script is already using $( ) and $(( )) which isn't supported by
some pre-POSIX shells.

As does the "runtest" script. The "dejagnu" script is simply following suit.


-- Jacob



reply via email to

[Prev in Thread] Current Thread [Next in Thread]