[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PATCH: add dejagnu-report-card(1) tool (run as "dejagnu report card"

From: Ben Elliston
Subject: Re: PATCH: add dejagnu-report-card(1) tool (run as "dejagnu report card")
Date: Sun, 30 Dec 2018 18:13:16 +1100
User-agent: NeoMutt/20170609 (1.8.3)

Hi Jacob

Some comments for your consideration --

On Sat, Dec 29, 2018 at 11:40:32PM -0600, Jacob Bachmeyer wrote:

> This patch is the long-promised dejagnu-report-card(1) tool,
> although it is not yet actually installed under that name, instead
> being run as "dejagnu report card" or "dejagnu report-card".

The former ("dejagnu report card") is confusing because "card" looks
like an argument. I think the launcher subcommands should not contain
spaces. dejagnu report-card seems natural enough to me.

> All three implementations are included in this patch.  Installing it
> as dejagnu-report-card simply requires making a symlink
> dejagnu-report-card -> dejagnu; the launcher will handle the rest if
> called via such a symlink.

As the person who gets to maintain this code, I'm really not a fan of
multiple implementations. I don't mind if it's sh, Tcl or AWK. I
understand the intrinsic value of n-version development in testing,
but in practice, I don't want multiple copies of the code that do the
same thing. Please just pick one on the criteria of performance or
maintainability and submit that, please.



Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]