dejagnu
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add baseboard for PRU simulator


From: Jacob Bachmeyer
Subject: Re: [PATCH] Add baseboard for PRU simulator
Date: Wed, 16 Dec 2020 20:48:46 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.22) Gecko/20090807 MultiZilla/1.8.3.4e SeaMonkey/1.1.17 Mnenhy/0.7.6.0

Dimitar Dimitrov wrote:
On сряда, 16 декември 2020 г. 5:41:23 EET Jacob Bachmeyer wrote:
Dimitar Dimitrov wrote:
I'm running [1] PRU regression tests using this baseboard definition and
mainline Binutils, GCC, Newlib and GNU Simulator.

[1] https://github.com/dinuxbg/gnupru/blob/master/testing/buildbot-pru.sh

ChangeLog:
        * Makefile.am: Add pru-sim.exp.
        * Makefile.in: Ditto.
        * baseboards/pru-sim.exp: New file.
I would like to accept this patch, and because it will not affect
existing code, I can slip it in before the release, but it does add a
new file, which makes triviality doubtful.  Was the new file trivially
derived (enough that I can accept the FSF copyright and license notice
as having been copied along with the rest of the file) from an existing
file?  If not, could you contact <assign@gnu.org> and ask for the
paperwork for copyright assignment for these changes to DejaGnu?

Thanks and thanks in advance,

-- Jacob
I took powerpc-sim and added pru-specific options.
  $ diff baseboards/powerpc-sim.exp baseboards/pru-sim.exp | diffstat
    1 file changed, 26 insertions(+), 8 deletions(-)

The timeout option was borrowed from mcore-sim.exp

I consider these trivial changes. Let me know if I need to obtain assignment.

Git identifies nearly everything except about 5 (largely functional) lines and a large-ish comment block as coming from other files, so I will accept that the file is trivially derived from existing files. Patch applied.

I will still encourage you to complete assignment papers for your contributions to DejaGnu, as that will smooth future contributions and DejaGnu is fairly closely affiliated to the GNU toolchain, although they are separate projects.


-- Jacob



reply via email to

[Prev in Thread] Current Thread [Next in Thread]