[Discuss-gnuradio] Re: [Hamlib-developer] [Patch] Proposed patch for easycom.c

[Stephane Fillod]

Hi Luc,

Your patch has been commited thanks. Would you like to be the maintainer
of the easycomm backend?
Please use unified (diff -u) patch format next time, it is much 
more readable.

73
-- 
Stephane

On Sat, Nov 19, 2005 at 01:38:55PM +0100, Luc Langehegermann wrote:
> Hi There,
> 
> I did a small modification to the easycom driver. 
> 
> Changed the limits to 0..360 fir Azimuth and 0..180 for Elevation. That was 
> -180.0..180.0 and 0..90. The devices I know about don't have negative azimuth 
> values.
> 
> 2. In rot_set_position, do not wait for a reply from the controller, as there 
> will not be one, according to the specifications I found at 
> http://www.amsat.org/amsat/ftp/software/win32/wisp/easycomm.txt
> 
> Index: easycomm.c
> ===================================================================
> RCS file: /cvsroot/hamlib/hamlib/easycomm/easycomm.c,v
> retrieving revision 1.6
> diff -r1.6 easycomm.c
> 83c83
> <     unsigned char cmdstr[64], ackstr[64];
> ---
> >     unsigned char cmdstr[64];
> 88c88
> <     retval = easycomm_transaction(rot, cmdstr, ackstr, sizeof(ackstr));
> ---
> >     retval = easycomm_transaction(rot, cmdstr, NULL, 0);
> 262,263c262,263
> <   .min_az =   -180.0,
> <   .max_az =   180.0,
> ---
> >   .min_az =   -0.0,
> >   .max_az =   360.0,
> 265c265
> <   .max_el =   90.0,
> ---
> >   .max_el =   180.0,
> 296,297c296,297
> <   .min_az =   -180.0,
> <   .max_az =   180.0,
> ---
> >   .min_az =   0.0,
> >   .max_az =   360.0,
> 299c299
> <   .max_el =   90.0,
> ---
> >   .max_el =   180.0,
> 
> 
> 
> 73, Luc