[Discuss-gnuradio] Peak detector block does not really work. It need to be fixed

[Phong Do]

Hello,

I'm working now with peak_detector block and find out that some functions
don't really work.
I've used the following 2 blocks: 

- Peak Detector (gr_peak_detector): the parameter "look ahead" seems have no
function. I gave "look ahead" many values but the peak value did not change.
I've seen in the gr_peak_detector_xx.cc that the variable d_look_ahead is
called but it is not used in the main program. So I think the developer has
forgotten this function.

- Peak Detector 2 (gr_peak_detector2): in this block "look ahead" is used,
but sometimes the peak detector freezes (output signal stops running in
scope sink). 
I've changed the cpp code a little bit and it does not freeze anymore. But
I'm not sure if the detector will work correctly after that. 
Here is what I've changed:
original code: return tmp - 1; 
changed code: return tmp;

Can anyone of the development team have a look at the 2 cpp ?

best regards
Phong Do

C++ code:
http://old.nabble.com/file/p29349773/gr_peak_detector_fb.cc
gr_peak_detector_fb.cc 
http://old.nabble.com/file/p29349773/gr_peak_detector2_fb.cc
gr_peak_detector2_fb.cc 

-- 
View this message in context: 
http://old.nabble.com/Peak-detector-block-does-not-really-work.-It-need-to-be-fixed-tp29415858p29415858.html
Sent from the GnuRadio mailing list archive at Nabble.com.