Re: [Discuss-gnuradio] Bug in gr_pll_carriertracking.cc

[Robert McGwier]

The last time I did this I had written the routine ....

;-)

Bob

On Nov 23, 2011 11:18 AM, "Ben Hilburn" <address@hidden> wrote:

Heh, sometimes you have to e-mail a public list before any of it makes sense.  Happens to me all the time =)

Cheers,

Ben

On Wed, Nov 23, 2011 at 8:53 AM, Marcus M <address@hidden> wrote:

On Wed, Nov 23, 2011 at 10:12 AM, Marcus M <address@hidden> wrote:

Hi,
I have the latest gnuradio release and I think the phase error calculation in gr_pll_carriertracking.cc might be wrong.

In Line 107 the phase error is calculated as,
error = phase_detector(iptr[i],d_phase);

whereas, I think it should be as shown below as the phase error is calculated from the signal that has been corrected in phase.
error = phase_detector(optr[i],d_phase);

Am I right?

My bad. The phase_detector() function returns the difference. Ignore this message.

Thanks

_______________________________________________
Discuss-gnuradio mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio

_______________________________________________
Discuss-gnuradio mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio