Re: [Discuss-gnuradio] Mistake in fmdet_cf_impl.cc:109?

[Johnathan Corgan]

On Thu, Jul 11, 2013 at 3:37 AM, Perper <address@hidden> wrote:

 

I was reading the c++ code of FM demodulators in gnuradio and I
encountered this in fmdet_cf_impl.cc:109:

-------------------------------------
        Sdot = d_scl * (-S0+d_8*S1-d_8*S1+S4);
-------------------------------------

I don't know according to what principle this demodulator work exactly
but it doesn't seem to make too much sense to first add d_8*S1 and then
subtract it.

This code looks 'vestigial'; something left over from early development or debugging that wasn't removed.  I'll make a note to clean it up.

-- 

Johnathan Corgan
Corgan Labs - SDR Training and Development Services
http://corganlabs.com