Re: [Discuss-gnuradio] log2() missing in MSVC v16

[Martin Braun]

On 10/23/2014 03:38 PM, Tom Rondeau wrote:
> Looks like a missed to 'not's in there :) I'll patch this soon.

Untie the nots?
I shouldn't be joking, probably being the person who put them in...

>     > @@ -29,6 +29,16 @@
>     > +static inline double log2 (double x)
>     > +{
>     > +  return log ((double)x) / log (2.0F);
>     > +}
> 
>     This might be useful, but I can't say. However, please make this an
>     issue on the issue tracker, or it'll get lost.
> 
>     Cheers,
>     M
> 
> Also, considering that Windows XP is an unsupported operating system
> from Microsoft, we don't have much of an incentive to track it or keep
> things updated there. If your patches are trivial and don't bother
> anything else, then sure. But it looks like your patch here just shoves
> in the log2 without regard for whether or not log2 actually exists on
> the system. There's going to need to be a #if check around it. Perhaps
> Cmake can check for log2 and define a variable (HAVE_LOG2 or something)
> for this.

Actually, I just now ran into this elsewhere -- log2() is actually
C++11, which we don't officially support (although except for some
MSVCs, this stuff is pretty much available everywhere). Gisle, if you
could provide something like Tom suggested, that would be useful.

Cheers,
Martin