Re: [Discuss-gnuradio] Locking TopBlock stops WavFile-Sink

[Tom Rondeau]

On Mon, Jan 5, 2015 at 9:45 AM, Luke Berndt <address@hidden> wrote:

Awesome! That is totally it.

I went back and checked and the 3.6 version of wavfile_sink_impl does not have a stop function. It only closes the file when close() is called or the destructor.

This is a pretty big change from 3.6 to 3.7 and I didn't see it documented anywhere. Is this something I can add to the 3.6 -> 3.7 guide in the wiki? Is there a better place to capture some of the lower level changes?

That's the best place to add this change.

 

Are there any good guides that walk through the flows for high level functions? Like what calling lock() triggers in the blocks and the scheduler? It would make it a lot easier to walk through the code.

In order to solve my problem, it looks like I should create a custom version of wavfile_sink that doesn't have stop().

Thanks again!

 - Luke

You could try and modify the code to overload the start() function to open/reopen the file again (can't say for sure this will be safe with a wav file, though). Though probably easiest to create your own block as part of any oot module you've built for your projects.

Tom

 

On Mon, Jan 5, 2015 at 7:34 AM, Sylvain Munaut <address@hidden> wrote:

Hi,


When there is a lock()/unlock() cycle, the ->stop() will end up being
called on all the flowgraph() blocks.

The wavsink block does implement stop() and that's where it closes the
file and updates the wavheader.

But there is no implementation for start(), it actually opens the file
in the constructor, so it can't resume.


Cheers,

    Sylvain

_______________________________________________
Discuss-gnuradio mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio