Re: [Discuss-gnuradio] Softbits in gr-ieee 802.11 ?

[Michael Dickens]

So we mean adding "virtual" in the GR header here < 
https://github.com/sumitstop/MTSDR-gnuradio/commit/778b6d095517b87c338169e3efc84bac9fcf37ea#diff-96726df785ba7d3bf9493c8830d5a1d0R79
 >, just like the "decision_maker" method is. And you'll probably want to 
declare its function there too as "{}", so that there is a default provided in 
the base class & hence any inheriting class doesn't have to declare that method 
(as they do for "decision_maker").

Then when you overload the method in your gr-ieee-802.11 OOT you are not 
required to declare that method as virtual, but it doesn't hurt to do so & 
there are some who prefer that style of programming (making it explicit that 
the method is overloading a base class virtual method).

Because the gr-ieee-802.11 OOT constellation inherits from 
gr::digital::constellation (the "global" base class), you do have to modify 
both the GR header for constellation.h as well as the OOT "constellation_impl" 
header and c++ source to add in new methods. You also, of course, have to 
rebuild and reinstall (at least) GR, possibly also the OOT depending on how 
you're loading libraries etc.

Hence I think overloading the "calc_soft_dec" method would be a better way to 
go, since it doesn't require you to modify GR. - MLD

On Sun, Jan 21, 2018, at 1:48 PM, sumit kumar wrote:
> Believe me I tried that declaring decision_maker_soft as a virtual 
> function(only virtual not pure virtual), but that din't work. I am trying 
> that now again.