Re: OOT tests failing in GNU Radio 3.9.2.0, Ubuntu 20.04.2 LTS

[Anton Ottosson]

Hi Vasil,

Thank you for so generously taking time out of your day to look at this. I agree with your analysis and have now submitted an issue (https://github.com/gnuradio/gnuradio/issues/4825) about this to the GNU Radio GitHub repository.

However, it seems like I might have found an additional issue, possibly related. I wanted to make progress with the OOT tutorial (https://wiki.gnuradio.org/index.php/OutOfTreeModules), so i used Ron's suggested workaround with installing the module to get the tests to work. The new issue appears a bit later in the tutorial, when we attempt to add another block to the module. Instead of me describing it here, I have once again set up a GitHub repository (https://github.com/antonott/oot_tutorial_issue) to illustrate the problem. The README describes the process, and of course the rest of the repo contains the state of the module.

Regards,

Anton

---

From: Vasil Velichkov <vvvelichkov@gmail.com>
Sent: Tuesday, June 29, 2021 10:57:42 AM
To: Anton Ottosson; discuss-gnuradio@gnu.org
Subject: Re: OOT tests failing in GNU Radio 3.9.2.0, Ubuntu 20.04.2 LTS

 

Hi Anton,

On 28/06/2021 22.12, Anton Ottosson wrote:
> It indeed seems like the tests only work if I first install the module. I have set up a GitHub with the full source at https://github.com/antonott/oot_tests_failing. The README outlines the procedure used to build, test (and fail), install, and finally test again (and succeeding).

Look at https://github.com/antonott/oot_tests_failing/blob/main/build/python/qa_iqlevels_test.sh#L8-L9

  export PYTHONPATH=$PYTHONPATH
  /usr/bin/python3 /home/antonott/gr-iqlevels/python/qa_iqlevels.py

As suspected "/home/antonott/gr-iqlevels/python/" is not added to PYTHONPATH and when you run the tests it can't find your module. This seems to be broken since the migration from swig to pybind. Previously when swig was used the import statements in the python/qa_*.py files looked like this

   import oot_swig as oot

and build/swig was added to the PYTHONPATH in build/python/qa_*_test.sh

   export PYTHONPATH=/home/user/src/gr-oot/build/swig:$PYTHONPATH

Not sure how to fix this but I my option this needs to be fixed/improved.

Regards,
Vasil