RE: crashes on Solaris (was Re: how to load .gmodel file?)

[Naomaru Itoi]

Hi,

I had one more crash because of the problem similar to what Adam has fixed yesterday (referencing NULL struct).  I've applied a fix which also is similar to what Adam has done (just check for NULL struct).  Now crashes on Solaris seem to have gone, at least from applications I'm testing.

Here's the diff.  Please apply it if you prefer ... Thank you.

naomaru@demosunray1 in Source $ cvsstep diff -c GSSimpleLayoutManager.m
Index: GSSimpleLayoutManager.m
===================================================================
RCS file: /cvsroot/gnustep/gnustep/core/gui/Source/GSSimpleLayoutManager.m,v
retrieving revision 1.37
diff -c -r1.37 GSSimpleLayoutManager.m
*** GSSimpleLayoutManager.m     5 Dec 2002 04:50:30 -0000       1.37
--- GSSimpleLayoutManager.m     5 Dec 2002 19:27:50 -0000
***************
*** 933,943 ****
                                       - 1] lineFragmentRect]);
 
        displayRect.size.width = width;
!       displayRect.origin.x +=
!       [[aTextContainer textView] textContainerInset].width;
!       displayRect.origin.y +=
!       [[aTextContainer textView] textContainerInset].height;
!       [[aTextContainer textView] setNeedsDisplayInRect: displayRect];
      }
  }
 
--- 933,945 ----
                                       - 1] lineFragmentRect]);
 
        displayRect.size.width = width;
!       if (aTextContainer) {
!       displayRect.origin.x +=
!         [[aTextContainer textView] textContainerInset].width;
!       displayRect.origin.y +=
!         [[aTextContainer textView] textContainerInset].height;
!       [[aTextContainer textView] setNeedsDisplayInRect: displayRect];
!       }
      }
  }

> -----Original Message-----
> From: Adam Fedor [mailto:fedor@doc.com]
> Sent: Wednesday, December 04, 2002 8:55 PM
> To: Naomaru Itoi
> Cc: 'discuss-gnustep@gnu.org'
> Subject: Re: crashes on Solaris (was Re: how to load .gmodel file?)
>
>
>
>
> Naomaru Itoi wrote:
> > Thanks, Richard, Manuel.
> >
> > I installed libxml2-2.4.28, and it seems to parse the XML
> gmodel file
> > now.  Thank you.
> >
> > However, the application doesn't quite run yet.
> >
> > When I run my CurrencyConverter.app (which I ported from
> Cocoa sample),
> > I encounter the following:
> > - "Unable to initialize XIM, using standard keyboard events"
>
> That's expected, but if you know why this is, let me know.
> Perhaps XIM
> just doesn't work on Solaris.
>
> > When I ignore these error messages, two blank windows
> appear.   Then it
> > says:
> > - "Internal: No can't decode color space
> NSPatternColorSpace.  creating
> > generic white collor."
>
> Also expected.
>
> > - "Illegal Instruction (core dumped)"
> >
> > Please see the error messages (error.txt) and the output from gdb
> > (gdb.txt).  It dies in
> >
> _i_GSSimpleLayoutManager__textStorage_edited_range_changeInLen
> gth_invalidatedRange_
> > () .
> >
>
> Due to a Solaris limitation (can't set a structure to 0). I've fixed
> this to test for the problem. Pretty much anytime you get Illegal
> Instruction on Solaris, it's due to this kind of bug. Thanks
> for the bug
> report.
>