Re: latest theme changes make Thematic crash

[Wolfgang Lux]

Riccardo Mottola wrote:

> at first, I thought a reliable way of reproducing it. I was able to get it 
> crash also withhout saving or applying changes, just by openin a theme and 
> opening the inspector (without, with just the main document window it would 
> work). But then it proved that it wasn't always the case.
> 
> On linux, the stacktrace I got was:
> 
> #0  0xb76b10d5 in objc_msg_lookup ()
>   from /usr/lib/gcc/i686-pc-linux-gnu/4.7.2/libobjc.so.4
> #1  0xb7c287eb in -[NSApplication(Private) _targetForAction:window:] (
>    self=0x814d76c, _cmd=0xb7eef2a0 <_OBJC_SELECTOR_TABLE+3360>,
>    aSelector=0x8171338, window=0x84b0fe4) at NSApplication.m:3891
> #2  0xb7c28997 in -[NSApplication(Private) 
> _targetForAction:keyWindow:mainWindow:] (self=0x814d76c, _cmd=0xb7eeef48 
> <_OBJC_SELECTOR_TABLE+2504>,
>    aSelector=0x8171338, keyWindow=0x843a9a4, mainWindow=0x84b0fe4)
>    at NSApplication.m:3936
> #3  0xb7c2669f in -[NSApplication targetForAction:] (self=0x814d76c,
>    _cmd=0xb7eeef50 <_OBJC_SELECTOR_TABLE+2512>, aSelector=0x8171338)
>    at NSApplication.m:2297
> #4  0xb7c265fb in -[NSApplication targetForAction:to:from:] (
>    self=self@entry=0x814d76c,
>    _cmd=_cmd@entry=0xb7f40490 <_OBJC_SELECTOR_TABLE+1168>,
>    theAction=theAction@entry=0x8171338, theTarget=0x0,
>    sender=sender@entry=0x819e01c) at NSApplication.m:2273
> #5  0xb7cf7792 in -[NSMenu update] (self=0x819dfb4,
>    _cmd=0xb7f403d0 <_OBJC_SELECTOR_TABLE+976>) at NSMenu.m:1156
> #6  0xb7cf7918 in -[NSMenu update] (self=0x81b2d2c,
>    _cmd=0xb7eeee30 <_OBJC_SELECTOR_TABLE+2224>) at NSMenu.m:1151
> #7  0xb7c2b8b1 in -[NSApplication(Private) _windowDidBecomeKey:] (
>    self=0x814d76c, _cmd=0xb7eeecd0 <_OBJC_SELECTOR_TABLE+1872>,
> 
> in #1: window is:
> <NSWindow: 0x84b0fe4>Number: 681 Title: Sleek.theme
> This would be the main window.
> checking at #2 we see:
> <NSPanel: 0x843a9a4>Number: 722 Title: System Images Inspector
> (gdb) po mainWindow
> <NSWindow: 0x84b0fe4>Number: 681 Title: Sleek.theme
> 
> Sadly, what appeared to be easily reproducible, appeared not to when you try 
> to chase it with zombies. At one point however I got:
> 2013-04-09 12:36:25.421 Thematic[4601] *** -[ThemeDocument 
> respondsToSelector:]: message sent to deallocated instance 0x88ddeb4
> 2013-04-09 12:36:25.421 Thematic[4601] *** -[ThemeDocument 
> respondsToSelector:]: message sent to deallocated instance 0x88ddeb4
> 
> I tried to poke with a breakpoint in GSLogZombie but got lost.
> 
> it appears the culprit is the disappearing of ThemeDocument itself, then, 
> right?

Probably. This is somewhat odd as ThemeDocument sets the delegate of its window 
to nil when it is deallocated. So maybe the theme document is set as delegate 
of other windows besides the document window. You might checking by setting a 
breakpoint on NSWindow's setDelegate: method. Apart from that you can set a 
breakpoint in the dealloc method of ThemeDocument to see when it gets 
deallocated.

Wolfgang