[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [dmidecode] [PATCH v2 1/4] dmidecode: Make dmi_print_memory_size glo
From: |
Jean Delvare |
Subject: |
Re: [dmidecode] [PATCH v2 1/4] dmidecode: Make dmi_print_memory_size global. |
Date: |
Tue, 12 Jan 2021 15:41:52 +0100 |
On Tue, 12 Jan 2021 01:05:02 -0700, Jerry Hoemann wrote:
> Make dmi_print_memory_size() global so that it can be called from
> outside of dmidecode.c
>
> Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
> ---
> dmidecode.c | 2 +-
> dmidecode.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/dmidecode.c b/dmidecode.c
> index 864a193..2a075c1 100644
> --- a/dmidecode.c
> +++ b/dmidecode.c
> @@ -267,7 +267,7 @@ static void dmi_dump(const struct dmi_header *h)
> }
>
> /* shift is 0 if the value is in bytes, 1 if it is in kilobytes */
> -static void dmi_print_memory_size(const char *attr, u64 code, int shift)
> +void dmi_print_memory_size(const char *attr, u64 code, int shift)
> {
> unsigned long capacity;
> u16 split[7];
> diff --git a/dmidecode.h b/dmidecode.h
> index 1dc59a7..7e90fcb 100644
> --- a/dmidecode.h
> +++ b/dmidecode.h
> @@ -33,5 +33,6 @@ struct dmi_header
>
> int is_printable(const u8 *data, int len);
> const char *dmi_string(const struct dmi_header *dm, u8 s);
> +void dmi_print_memory_size(const char *addr, u64 code, int shift);
>
> #endif
Looks good, thanks.
--
Jean Delvare
SUSE L3 Support
[dmidecode] [PATCH v2 4/4] dmioem: Fix HPE OEM 236, Jerry Hoemann, 2021/01/12