|
From: | Marcos García |
Subject: | Re: [Dolibarr-dev] dol_getmypid |
Date: | Fri, 8 Aug 2014 12:40:07 +0200 |
I've commented the problem to the author in the bug report made by Régis in 2011: https://sourceforge.net/p/tcpdf/bugs/602/
We should consider updating TCPDF library in 3.7 once they patch that.Regards,2014-08-04 12:08 GMT+02:00 Doursenaud, Raphaël <address@hidden>:I don't think using dol_getmypid in scripts is a wise idea.The whole purpose of outputting the PID in the CLI is to be able to kill the process. We don't want to display a random number!People having the right to execute scripts on their hosting should have the right to use the getmypid() function anyway.Also, the getmypid usage in TCPDF is just to get some entropy to generate a random seed. We could have removed it altogether because there is already quite a lot of entropy in the other parameters inferred.My 2 cents.This is a verbatim copy of my comment at https://github.com/Dolibarr/dolibarr/commit/212e9825a3974bbef19f96405c26eae63eb0a828#commitcomment-7252125Cheers,2014-08-01 9:44 GMT+02:00 Florian HENRY <address@hidden>:
Hello Marcos
It come from the french forum (http://www.dolibarr.fr/forum/3-installation/50977-probleme-d-installation-chez-un-hebergeur-gratuit)
Some free hosting service remove getmypid for security reason. As this is not a real must have for dolibarr running, a developper send this pull request, and Laurent integrate it.
Regards
Florian Henry +33 6 03 76 48 07 address@hidden http://www.open-concept.pro Twitter : @_Open_Concept_ Google+ : https://plus.google.com/+FlorianHENRYLe 31/07/2014 20:26, Marcos García a écrit :
Hi all:
I've noticed a PR made by frederic (https://github.com/Dolibarr/dolibarr/pull/1792) was accepted, and so getmypid was renamed to dol_getmypid.
My question is: why was that made? The check if function does not exists before recreating the function getmypid wasn't enough?
I brought the discussion to the ML because I think it is a better place to discuss this things.
Regards,
_______________________________________________ Dolibarr-dev mailing list address@hidden https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
_______________________________________________
Dolibarr-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
--Raphaël DoursenaudDirecteur technique (CTO)
Technopole Hélioparc2 avenue du Président Pierre Angot64053 PAU CEDEX 9SARL GPC.solutions au capital de 7 500 € - R.C.S. PAU 528 995 921
_______________________________________________
Dolibarr-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
[Prev in Thread] | Current Thread | [Next in Thread] |