bug#43198: closed (Add breeze icon assets)

[GNU bug Tracking System]

Your message dated Wed, 09 Sep 2020 09:26:34 +0200
with message-id <87zh5zmmvp.fsf@gnu.org>
and subject line Re: [bug#43198] Add breeze icon assets
has caused the debbugs.gnu.org bug report #43198,
regarding Add breeze icon assets
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
43198: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43198
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: Add breeze icon assets Date: Fri, 4 Sep 2020 14:07:27 +0545

Esteemed maintainers,

I submit the following two patches to you for review.

They add breeze-assets and breeze packages.

Currently, guix only has `breeze-icons`, and this package only supplies the icons, and not the entire breeze theme.

I have, however, a few concerns/comments regarding the patches.

# Regarding the first patch:

1. Regarding `breeze-assets`, I am not entirely sure if that is the right name for the package. If there are any better suggestions, perhaps it should be changed (?)

2. The `breeze-assets` package inheriting from `breeze-icons` package is intentional: so as to show the relationship. I started with `guix environment breeze-icons --ad-hoc stuffs` to package breeze-assets, anyways. I think this makes it more read-able. (Can we keep it, please?)

3. I could not really find a proper home-page for the package.

4. I wonder if there should be better synopsis/description? But I'm not sure. But if I get an 'it's all right', I'd like to run with it as-is, please.

# Regarding the second patch:

1. I intentionally used (inherit, again, and used (@ to inherit from mate.scm. Probably a bad idea. And it got me thinking, since union-builds aren't all that common yet, perhaps a boilerplate union-build package could be created. I saw that `mate` and `xfce` use almost identical package definitions. Perhaps abstracting that away into some hidden package like (@@ (guix some place) union-build-boilerplate) or something would keep us from repeating ourselves? I understand that inheriting from something from an entirely different desktop-environment might be too much spaghetti code. And I am in favour of changing this. However, I send this patch in as a sample of how having union-build boilerplate might help us.

2. I am not entirely certain what the version number should be. It seems `breeze-icons` and `breeze-assets` differ in their latest version. But since `breeze-assets` is the bigger of the two packages, I decided to go with `breeze-assets`'s version number.

I hope to learn a lot from the review of these patches, and will try to send updated/polished patches - as per the reviews - as promptly as possible.

Thank you

0001-gnu-kde-frameworks-Add-breeze-assets.patch
Description: Text Data

0002-gnu-kde-frameworks-Add-breeze.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#43198] Add breeze icon assets
>
>
>
>
> Date: 
>
> Wed, 09 Sep 2020 09:26:34 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
>
>
>
>
> Hi,
>
> Prafulla Giri <pratheblackdiamond@gmail.com> skribis:
>
> > From 8096401f6f977cf48b66914e161da0efd124931e Mon Sep 17 00:00:00 2001
> > From: Prafulla Giri <pratheblackdiamond@gmail.com>
> > Date: Fri, 4 Sep 2020 12:56:26 +0545
> > Subject: [PATCH 1/2] gnu: kde-frameworks: Add breeze-assets
> >
> > * gnu/packages/kde-frameworks.scm (breeze-assets): New variable.
>
> Applied.
>
> > From b7d4e572923a98cc4ff266e95a3bd247556fb834 Mon Sep 17 00:00:00 2001
> > From: Prafulla Giri <pratheblackdiamond@gmail.com>
> > Date: Fri, 4 Sep 2020 12:59:28 +0545
> > Subject: [PATCH 2/2] gnu: kde-frameworks: Add breeze
> >
> > * gnu/packages/kde-frameworks.scm (breeze): New variable.
>
> [...]
>
> > +    (synopsis "Full Breeze Theme")
> > +    (description "The full Breeze visual style: a union-build of
> > +breeze-assets and breeze-icons.")
>
> I tweaked these and applied it.
>
> Thank you!
>
> Ludo’.
>
> PS: Please keep the bug Cc’d.
>
>
> --- End Message ---