bug#42634: closed ([PATCH 0/3] Add image-type support.)

[GNU bug Tracking System]

Your message dated Wed, 30 Sep 2020 11:51:33 +0200
with message-id <874knfd23e.fsf@gnu.org>
and subject line Re: [bug#42634] [PATCH 3/3] scripts: system: Add support for 
image-type.
has caused the debbugs.gnu.org bug report #42634,
regarding [PATCH 0/3] Add image-type support.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
42634: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=42634
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/3] Add image-type support.
>
>
>
>
> Date: 
>
> Fri, 31 Jul 2020 16:48:25 +0200
>
>
>
>
> Hello,
>
> This is the missing piece for the new image API. It has been previously
> discussed here[1].
>
> I think this is close to what Ludo suggested and it addresses janneke concerns
> about composability.
>
> The idea is to introduce the concept of "image-type". An image type is a
> converter from an <operating-system> record to an <image> record.
>
> I have created in this serie 4 new image type records:
> - raw
> - iso9660
> - uncompressed-iso9660
> - hurd-raw
>
> I also adapted the "guix system" command by removing the "file-system-type"
> argument and replaced it by the "image-type" argument.
>
> The default is still to create a raw disk-image, but one can now call:
>
> guix system disk-image -t iso9660 my-config.scm
> guix system disk-image -t uncompressed-iso9660 my-config.scm
> guix system disk-image -t hurd-raw my-config.scm
>
> and so on. Maybe we should also rename "disk-image" command to "image" that
> would be somehow more accurate.
>
> The only missing bit is the documentation update, as I prefer to wait for this
> change to be approved first.
>
> WDYT?
>
> Thanks,
>
> Mathieu
>
> [1]: https://lists.gnu.org/archive/html/guix-devel/2020-05/msg00417.html
>
> Mathieu Othacehe (3):
>   image: Add image-type support.
>   system: image: Add image-type support.
>   scripts: system: Add support for image-type.
>
>  gnu/image.scm              | 29 ++++++++++++++-
>  gnu/system/image.scm       | 75 ++++++++++++++++++++++++++++++++++++--
>  gnu/system/images/hurd.scm | 13 +++++--
>  guix/scripts/system.scm    | 56 +++++++++++++++++-----------
>  4 files changed, 145 insertions(+), 28 deletions(-)
>
> -- 
> 2.26.2
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#42634] [PATCH 3/3] scripts: system: Add support for image-type.
>
>
>
>
> Date: 
>
> Wed, 30 Sep 2020 11:51:33 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
>
>
>
>
> > Perhaps you can also add a ‘guix system list-image-types’ command to
> > tests/guix-system.sh for good measure.  That’d at least catch broken
> > modules and similar.
>
> Sure, fixed. I pushed this serie with the according documentation
> update.
>
> Thanks,
>
> Mathieu
>
>
> --- End Message ---