bug#52220: closed (29.0.50; [PATCH] Declare struct predicates as pure functions)

[GNU bug Tracking System]

Your message dated Wed, 01 Dec 2021 21:23:02 +0000
with message-id <xjfilw8xbnt.fsf@ma.sdf.org>
and subject line Re: bug#52220: 29.0.50; [PATCH] Declare struct predicates as 
pure functions
has caused the debbugs.gnu.org bug report #52220,
regarding 29.0.50; [PATCH] Declare struct predicates as pure functions
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
52220: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52220
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 29.0.50; [PATCH] Declare struct predicates as pure functions
>
>
>
>
> Date: 
>
> Wed, 01 Dec 2021 10:29:42 +0000
>
>
>
>
> Hi all,
>
> shouldn't we declare structure predicates as pure functions?
>
> Proposed patch attached.
>
> Thanks
>
>   Andrea
>
> >From 8382e2078295d6feb4abbe72cf671a61a84fc640 Mon Sep 17 00:00:00 2001
> From: Andrea Corallo <akrl@sdf.org>
> Date: Wed, 1 Dec 2021 11:23:25 +0100
> Subject: [PATCH] * lisp/emacs-lisp/cl-macs.el (cl-defstruct): Decl struct
>  predicates as pure
>
> ---
>  lisp/emacs-lisp/cl-macs.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el
> index 1852471bcb..9c9a778f04 100644
> --- a/lisp/emacs-lisp/cl-macs.el
> +++ b/lisp/emacs-lisp/cl-macs.el
> @@ -3050,7 +3050,7 @@ cl-defstruct
>                              `(,predicate cl-x))))
>      (when pred-form
>        (push `(,defsym ,predicate (cl-x)
> -               (declare (side-effect-free error-free))
> +               (declare (side-effect-free error-free) (pure t))
>                 ,(if (eq (car pred-form) 'and)
>                      (append pred-form '(t))
>                    `(and ,pred-form t)))
> -- 
> 2.20.1
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#52220: 29.0.50; [PATCH] Declare struct predicates as pure functions
>
>
>
>
> Date: 
>
> Wed, 01 Dec 2021 21:23:02 +0000
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
>
>
>
>
> Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of
> text editors" <bug-gnu-emacs@gnu.org> writes:
>
> > Lars Ingebrigtsen [2021-12-01 21:32:43] wrote:
> >> Andrea Corallo <akrl@sdf.org> writes:
> >>> shouldn't we declare structure predicates as pure functions?
> >> I think that's correct?
> >
> > Sounds right, yes.
> >
> >
> >         Stefan
>
> Right, installed as c35c86a353, closing.
>
> Thanks
>
>   Andrea
>
>
> --- End Message ---