emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#52532: closed ([PATCH] ci: Restrict substitute search to guix jobset


From: GNU bug Tracking System
Subject: bug#52532: closed ([PATCH] ci: Restrict substitute search to guix jobset.)
Date: Sun, 19 Dec 2021 15:31:02 +0000

Your message dated Sun, 19 Dec 2021 16:30:34 +0100
with message-id <87lf0gehnp.fsf@gnu.org>
and subject line Re: bug#52532: [PATCH] ci: Restrict substitute search to guix 
jobset.
has caused the debbugs.gnu.org bug report #52532,
regarding [PATCH] ci: Restrict substitute search to guix jobset.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
52532: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52532
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH] ci: Restrict substitute search to guix jobset. Date: Thu, 16 Dec 2021 01:14:02 +0000
Hi!

I've been using channel-with-substitutes-available recently, and
noticed that at one point it's returned a commit from the staging
branch instead of master.  On further investigation, it seems the API
needs a jobset parameter to restrict the results to only main guix
builds.

eg. http://ci.guix.gnu.org/api/latestbuilds?nr=5&job=guix.x86_64-linux
vs. 
http://ci.guix.gnu.org/api/latestbuilds?nr=5&job=guix.x86_64-linux&jobset=guix

Hopefully the above shows the problem, the first link includes builds
with jobset "staging" which probably shouldn't be returned as a
suitable guix revision for guix pull.

This patch adds a jobset parameter to restrict the substitute search.

Cheers,
Andrew

Attachment: guix-restrict-substitute-jobset.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#52532: [PATCH] ci: Restrict substitute search to guix jobset. Date: Sun, 19 Dec 2021 16:30:34 +0100 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
Hey Andrew,

> Hopefully the above shows the problem, the first link includes builds
> with jobset "staging" which probably shouldn't be returned as a
> suitable guix revision for guix pull.

Oh I guess it picked the "guix" package from the staging specification
which has noting to do with the "guix" package from the "guix"
specification. Hard to follow, naming could probably be improved here
:).

The first one is the package from (gnu packages package-management)
while the second is the guix modular package from the (build-self)
module.

Anyway your patch should prevent this problem from happening. Pushed as
11334d15d590073c631c574436d2110aa1ea2142.

Thanks,

Mathieu


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]