bug#52710: closed ([PATCH 0/2] Update Disarchive)

[GNU bug Tracking System]

Your message dated Wed, 22 Dec 2021 13:49:36 -0500
with message-id <877dbweapr.fsf@ngyro.com>
and subject line Re: bug#52710: [PATCH 0/2] Update Disarchive
has caused the debbugs.gnu.org bug report #52710,
regarding [PATCH 0/2] Update Disarchive
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
52710: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52710
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/2] Update Disarchive
>
>
>
>
> Date: 
>
> Tue, 21 Dec 2021 13:20:42 -0500
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hello,
>
> These two patches update Disarchive to 0.4.0.  This version of Disarchive has
> support for XZ, which requires Guile-LZMA.  Since Disarchive is a dependency
> of the Guix package, I’m hoping someone else can look over the patches before
> I push them.
>
> I made sure to check the following things:
>
>   • Building the Guix package
>   • Running ‘guix pull’
>   • Recovering a GZip-compressed tarball from Guix
>   • Recovering a XZ-compressed tarball from Guix
>   • Cross-compiling Guile-LZMA, Disarchive, and Guix itself
>   • Running Guix from a cross-built Hurd image
>
> I couldn’t use Disarchive recovery from the Hurd, but I’m inclined to
> assume that it’s not a regression [1].  Other than that, everything seemed
> okay to me.
>
> If you want to test recovering an XZ source, you can use (amusingly)
> the ‘gzip’ package source code (as of writing it’s the only XZ spec
> available).  You need to run the Guix daemon in an environment that
> provides the new Disarchive and Guile-LZMA (I used ‘./pre-inst-env
> guix shell -D guix’).  Then, you can run
>
>   $ GUIX_DOWNLOAD_FALLBACK_TEST=disarchive-mirrors \
>         ./pre-inst-env guix build --check -S gzip
>
> Thanks in advance!
>
> [1]: AFAICS, it fails when the SWH downloader tries to pipe the tarball
> it’s downloading into ‘tar’ to extract it.
>
>
> -- Tim
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#52710: [PATCH 0/2] Update Disarchive
>
>
>
>
> Date: 
>
> Wed, 22 Dec 2021 13:49:36 -0500
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hi Mathieu,
>
> Mathieu Othacehe <othacehe@gnu.org> writes:
>
> > Hello Timothy,
> >
> >> +    (native-inputs
> >> +     `(("autoconf" ,autoconf)
> >> +       ("automake" ,automake)
> >> +       ("guile" ,guile-3.0)
> >> +       ("guile-bytestructures" ,guile-bytestructures)
> >> +       ("pkg-config" ,pkg-config)))
> >> +    (inputs
> >> +     `(("guile" ,guile-3.0)
> >> +       ("xz" ,xz)))
> >> +    (propagated-inputs
> >> +     `(("guile-bytestructures" ,guile-bytestructures)))
> >
> > You should update those to fit the new style.
>
> Of course!  Old habits....  :)
>
> > Otherwise looks fine!
> >
> > Thanks,
>
> Pushed.  Thank you!
>
>
> -- Tim
>
>
> --- End Message ---