emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#50796: closed ([PATCH] gnu: Add pn.)


From: GNU bug Tracking System
Subject: bug#50796: closed ([PATCH] gnu: Add pn.)
Date: Fri, 12 Aug 2022 14:40:01 +0000

Your message dated Fri, 12 Aug 2022 17:39:48 +0300
with message-id <YvZmNEWDjMiqeFXE@pbp>
and subject line Re: [bug#50796] [PATCH] gnu: Add pn.
has caused the debbugs.gnu.org bug report #50796,
regarding [PATCH] gnu: Add pn.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
50796: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=50796
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH] gnu: Add pn. Date: Fri, 24 Sep 2021 23:28:15 -0400
* gnu/packages/telephony.scm (pn): New variable.
---
Add pn and its dependencies.
It's a phone number CLI tool used by Linux phone GUIs like SXMO.

 gnu/packages/telephony.scm | 72 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 72 insertions(+)

diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
index 48bbe12920..9015cf536a 100644
--- a/gnu/packages/telephony.scm
+++ b/gnu/packages/telephony.scm
@@ -20,6 +20,7 @@
 ;;; Copyright © 2020, 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
 ;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com>
 ;;; Copyright © 2021 LibreMiami <packaging-guix@libremiami.org>
+;;; Copyright © 2021 Antero Mejr <antero@mailbox.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -54,12 +55,14 @@
   #:use-module (gnu packages documentation)
   #:use-module (gnu packages file)
   #:use-module (gnu packages protobuf)
+  #:use-module (gnu packages gawk)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages gtk)
+  #:use-module (gnu packages icu4c)
   #:use-module (gnu packages image)
   #:use-module (gnu packages libcanberra)
   #:use-module (gnu packages linphone)
@@ -907,3 +910,72 @@ Initiation Protocol (SIP) and a multimedia framework.")
 telephony functionality into custom Telegram clients.")
     (home-page "https://github.com/zevlg/libtgvoip";)
     (license license:unlicense)))
+
+(define-public libphonenumber
+  (package
+    (name "libphonenumber")
+    (version "8.12.33")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/google/libphonenumber";)
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+         (base32
+          "0r12icyig6jy0v87j9n3w14acfa2yfckzzfbmnjx1hww6qc9ih25"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f
+       #:phases
+        (modify-phases %standard-phases
+          (add-after 'unpack 'enter-dir
+            (lambda _ (chdir "cpp") #t)))))
+    (inputs
+     `(("boost" ,boost)
+       ("googletest" ,googletest)
+       ("protobuf" ,protobuf)
+       ("icu4c" ,icu4c)))
+    (home-page "https://github.com/google/libphonenumber";)
+    (synopsis "C++ library for phone number parsing")
+    (description
+     "libphonenumber is Google's common Java, C++ and JavaScript library for
+parsing, formatting, and validating international phone numbers.")
+    (license license:asl2.0)))
+
+(define-public pn
+  (package
+    (name "pn")
+    (version "0.9.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/Orange-OpenSource/pn";)
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1lvzb0yixj7wmmqzsri20k9nn3gf06j0yjvmg2mi1zihywq7s4dx"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f
+       #:phases
+        (modify-phases %standard-phases
+         (add-after 'unpack 'sub-bin-path
+           (lambda _
+             (substitute* "CMakeLists.txt" (("DESTINATION \\$\\{AWKLIBPATH\\}")
+                                             "DESTINATION bin")))))))
+    (inputs
+     `(("libphonenumber" ,libphonenumber)
+       ("icu4c" ,icu4c)
+       ("protobuf" ,protobuf)
+       ("gawk" ,gawk)))
+    (home-page "https://github.com/Orange-OpenSource/pn";)
+    (synopsis "Command-line validation tool for phone numbers")
+    (description
+     "pn is a tool that allows command line user/programmers to operate on
+phone numbers (get validity information, reformat them, or extract numbers
+from a text snippet), using libphonenumber.")
+    (license license:asl2.0)))
-- 
2.30.2




--- End Message ---
--- Begin Message --- Subject: Re: [bug#50796] [PATCH] gnu: Add pn. Date: Fri, 12 Aug 2022 17:39:48 +0300
I pushed the patch with a few changes.

On Thu, Aug 11, 2022 at 03:11:05PM -0400, Antero Mejr via Guix-patches via 
wrote:
> * gnu/packages/messaging.scm (pn): New variable.
> ---
> Updated with new gexps and retested.
> 
> gnu/packages/messaging.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
> index 47798c3586..704feb1177 100644
> --- a/gnu/packages/messaging.scm
> +++ b/gnu/packages/messaging.scm
> @@ -3446,4 +3446,35 @@ (define-public python-harmony
>      (home-page "https://github.com/taylordotfish/harmony";)
>      (license license:gpl3+)))
>  
> +(define-public pn
> +  (package
> +    (name "pn")
> +    (version "0.9.0")
> +    (home-page "https://github.com/Orange-OpenSource/pn";)
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url home-page)
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "1lvzb0yixj7wmmqzsri20k9nn3gf06j0yjvmg2mi1zihywq7s4dx"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     (list #:tests? #f ;no tests
> +           #:phases #~(modify-phases %standard-phases
> +                        (add-after 'unpack 'sub-bin-path
> +                          (lambda _
> +                            (substitute* "CMakeLists.txt"
> +                              (("DESTINATION \\$\\{AWKLIBPATH\\}")
> +                               "DESTINATION bin")))))))

I changed the DESTINATION so that the library would install to
#$output/lib.

> +    (inputs (list libphonenumber icu4c protobuf))

I re-sorted the inputs alphabetically.

> +    (synopsis "Command-line validation tool for phone numbers")
> +    (description
> +     "@code{pn} provides a command line tool that allows users to operate on
> +phone numbers (get validity information, reformat them, or extract numbers 
> from
> +a text snippet), using @code{libphonenumber}.")
> +    (license license:asl2.0)))
> +
>  ;;; messaging.scm ends here
> -- 
> 2.37.1
> 
> 
> 
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Attachment: signature.asc
Description: PGP signature


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]