bug#57173: closed ([PATCH] gnu: yt-dlp: Update to 2022.08.08.)

[GNU bug Tracking System]

Your message dated Sat, 13 Aug 2022 16:19:46 +0200
with message-id <877d3cnre3.fsf@nckx>
and subject line Re: [bug#57173] [PATCH] gnu: yt-dlp: Update to 2022.08.08.
has caused the debbugs.gnu.org bug report #57173,
regarding [PATCH] gnu: yt-dlp: Update to 2022.08.08.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
57173: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57173
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: yt-dlp: Update to 2022.08.08.
>
>
>
>
> Date: 
>
> Sat, 13 Aug 2022 15:53:01 +0200
>
>
>
>
> * gnu/packages/video.scm (yt-dlp): Update to 2022.08.08.
>   [source]: remove snippet, switch to git-fetch
> ---
>  gnu/packages/video.scm | 23 ++++++-----------------
>  1 file changed, 6 insertions(+), 17 deletions(-)
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index 6d0b5ccb58..94ef3f0468 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -2486,26 +2486,15 @@ (define-public youtube-dl
>  (define-public yt-dlp
>    (package/inherit youtube-dl
>      (name "yt-dlp")
> -    (version "2022.07.18")
> +    (version "2022.08.08")
>      (source (origin
> -              (method url-fetch)
> -              (uri (string-append "https://github.com/yt-dlp/yt-dlp/";
> -                                  "releases/download/"
> -                                  version "/yt-dlp.tar.gz"))
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/yt-dlp/yt-dlp/";)
> +                    (commit version)))
>                (sha256
>                 (base32
> -                "1wmzfqhysx1mqdba4ikvm6nbahasihi4xgqwqad20y3vs701slyj"))
> -              (snippet
> -               #~(begin
> -                   ;; Delete the pre-generated files, except for the man page
> -                   ;; which requires 'pandoc' to build.
> -                   (for-each delete-file
> -                             (list "yt-dlp"
> -                                   ;;pandoc is needed to generate
> -                                   ;;"yt-dlp.1"
> -                                   "completions/bash/yt-dlp"
> -                                   "completions/fish/yt-dlp.fish"
> -                                   "completions/zsh/_yt-dlp"))))))
> +                "07qz1zdndlpki0asw35zk5hdjcwpl3n1g54nxg4yb1iykbyv7rll"))))
>      (arguments
>       (substitute-keyword-arguments (package-arguments youtube-dl)
>         ((#:tests? _) #t)
> -- 
> 2.37.1
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#57173] [PATCH] gnu: yt-dlp: Update to 2022.08.08. Date: Sat, 13 Aug 2022 16:19:46 +0200

Hi raingloom,

raingloom 写道：

* gnu/packages/video.scm (yt-dlp): Update to 2022.08.08.

Thanks!

Since yt-dlp was already up to date, I've turned this into a ‘fetch from git’ patch with the following additions:

  [source]: remove snippet, switch to git-fetch

 ^^ extraneous indentation; s/remove/Remove/.

When using GIT-FETCH, always set the file-name to something meaningful:

 (file-name (git-file-name name version))

- ;; Delete the pre-generated files, except for the man page

-                   ;; which requires 'pandoc' to build.

OK, but then we do need to build it ourselves, not remove it.

Done in c2481b1bea56f2885110d5af0a6cff36a3d95933.

The new package works fine, but differs slightly: extractor/lazy_extractors.py is no longer installed. What's up with that?

Leaving open for now,

T G-R

signature.asc
Description: PGP signature

--- End Message ---