bug#56896: closed (29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark)

[GNU bug Tracking System]

Your message dated Mon, 15 Aug 2022 21:17:15 -0700
with message-id <cd9d8942-d24f-e844-8e01-1526eeb5bb0e@gmail.com>
and subject line Re: bug#56896: 29.0.50; [PATCHv3] Make the bookmark fringe 
icon look like a bookmark
has caused the debbugs.gnu.org bug report #56896,
regarding 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
56896: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56896
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Date: Tue, 2 Aug 2022 12:13:44 -0700 Currently, the bookmark fringe icon is a circle. However, Emacs already uses a circle to represent breakpoints (as do a lot of other IDEs). These are usually a different color, but I think it would be nice if the bookmark fringe icon were a different shape too. This would help colorblind users, since (depending on their Emacs theme and what kind of colorblindness they have), it might be hard to distinguish the bookmark icon from the breakpoint icon.

It would help make the purpose of the indicator more obvious to users who don't directly use bookmarks. Some packages (including the built-in org-capture package) set bookmarks automatically, and a user might not realize that the dot indicates a bookmark, as opposed to some other thing.

Attached are some screenshots showing before/after, plus a patch for this. I converted the string definition of the bitmap to a vector of (binary) numbers, since then a reader can see the shape of the icon if they look carefully.

0001-Make-the-bookmark-fringe-icon-look-like-a-bookmark.patch
Description: Text document

before.png
Description: PNG image

after.png
Description: PNG image

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#56896: 29.0.50; [PATCHv3] Make the bookmark fringe icon look like a bookmark
>
>
>
>
> Date: 
>
> Mon, 15 Aug 2022 21:17:15 -0700
>
>
>
>
> On 8/14/2022 11:44 PM, Lars Ingebrigtsen wrote:
> > Makes sense to me; please go ahead and push.
>
> Thanks. Pushed as b87400c78b047d242ae188c46c621e0e8a8e69b2.
>
>
> --- End Message ---