bug#57353: closed ([PATCH] Fix parse-colon-path with UNC directory names)

[GNU bug Tracking System]

Your message dated Wed, 24 Aug 2022 19:21:47 +0300
with message-id <835yih6290.fsf@gnu.org>
and subject line Re: bug#57353: [PATCH] Fix parse-colon-path with UNC directory 
names
has caused the debbugs.gnu.org bug report #57353,
regarding [PATCH] Fix parse-colon-path with UNC directory names
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
57353: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57353
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] Fix parse-colon-path with UNC directory names Date: Tue, 23 Aug 2022 12:34:02 +0100

The function `parse-colon-path' changes the leading double slash
in a UNC path component to a single slash:

(let path (mapconcat path-separator "one" "//server/share/dir")
     (parse-colon-path path))
## -> ("one" "/server/share/dir")

A comment in `parse-colon-path' says:

;; Previous implementation used `substitute-in-file-name'
;; which collapse multiple "/" in front.  Do the same for
;; backward compatibility.

However, `substitute-in-file-name' does not do that:

(substitute-in-file-name "//foo/a/b") // -> "//foo/a/b"

There's no reason to do it in `parse-colon-path' either.

0001-Fix-parse-colon-path-with-UNC-directory-names.patch
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#57353: [PATCH] Fix parse-colon-path with UNC directory names
>
>
>
>
> Date: 
>
> Wed, 24 Aug 2022 19:21:47 +0300
>
>
>
>
> > From: Richard Copley <rcopley@gmail.com>
> > Date: Wed, 24 Aug 2022 15:23:56 +0100
> > Cc: 57353@debbugs.gnu.org
> > 
> > On Wed, 24 Aug 2022 at 15:15, Eli Zaretskii <eliz@gnu.org> wrote:
> > >
> > > Does the patch below give good results in your use cases?
> > >
> > > diff --git a/lisp/files.el b/lisp/files.el
> > > index 8596d9a..26730df 100644
> > > --- a/lisp/files.el
> > > +++ b/lisp/files.el
> > > @@ -856,10 +856,16 @@ parse-colon-path
> > >                  (if (equal "" f) nil
> > >                    (let ((dir (file-name-as-directory f)))
> > >                      ;; Previous implementation used 
> > > `substitute-in-file-name'
> > > -                    ;; which collapse multiple "/" in front.  Do the same 
> > > for
> > > -                    ;; backward compatibility.
> > > -                    (if (string-match "\\`/+" dir)
> > > -                        (substring dir (1- (match-end 0))) dir))))
> > > +                    ;; which collapses multiple "/" in front, while
> > > +                    ;; preserving double slash where it matters.  Do
> > > +                    ;; the same for backward compatibility.
> > > +                    (if (string-match "\\`//+" dir)
> > > +                        (substring dir
> > > +                                   (- (match-end 0)
> > > +                                      (if (memq system-type
> > > +                                                '(windows-nt 'cygwin 
> > > 'ms-dos))
> > > +                                          2 1)))
> > > +                      dir))))
> > >                (split-string spath path-separator)))))
> > >
> > >  (defun cd-absolute (dir)
> > 
> > It does.
>
> Thanks, installed with minor changes, and closing the bug.
>
>
> --- End Message ---