bug#57088: closed ([PATCH] Add emacs-blight and emacs-lemon)

[GNU bug Tracking System]

Your message dated Fri, 26 Aug 2022 10:29:08 +0200
with message-id <87bks7qugb.fsf@nicolasgoaziou.fr>
and subject line Re: [bug#57088] [PATCH] Add emacs-blight and emacs-lemon
has caused the debbugs.gnu.org bug report #57088,
regarding [PATCH] Add emacs-blight and emacs-lemon
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
57088: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57088
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] Add emacs-blight and emacs-lemon Date: Tue, 9 Aug 2022 18:57:04 +0000

0001-gnu-Add-emacs-blight.patch
Description: 0001-gnu-Add-emacs-blight.patch

0002-gnu-Add-emacs-lemon.patch
Description: 0002-gnu-Add-emacs-lemon.patch

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#57088] [PATCH] Add emacs-blight and emacs-lemon
>
>
>
>
> Date: 
>
> Fri, 26 Aug 2022 10:29:08 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
>
>
>
>
> Hello,
>
> Baptiste Strazzulla <bstrazzull@hotmail.fr> writes:
>
> > Subject: [PATCH 1/2] gnu: Add emacs-blight
>
> Applied with the following changes. Thank you.
>
> > +(define-public emacs-blight
> > +  (let ((commit "6bf9c6192d")
>
> Changed to a full hash.
>
> > +        (revision "0"))
> > +    (package
> > +      (name "emacs-blight")
> > +      (version (git-version "1.0.0" revision commit))
>
> AFAICT, there is no mention of a version number whatsoever across the
> code base. I set the base version to 0 instead.
>
> > +      (description
> > +       "@code{blight} allows you to control display brightness from Emacs.  
> > It
> > +features object-oriented code using EIEIO, a base class implementing a
> > +reasonable API which focuses on the extremely basic \"set the back light to
> > +this percentage\" functionality instead of advanced tightly-coupled frippery,
> > +it includes a concrete implementation that uses SysFS to control brightness.
> > +Other systems (D-Bus, macOS, Windows, xbacklight, XELB using XRandR) are
> > +easily supportable, giving the same experience across environments.  It has a
> > +500% snappier name than any other backlight tool for Emacs.")
>
> I trimmed down the description a bit.
>
> > +(define-public emacs-lemon
> > +  (let ((commit "37a6e6d6ef")
>
> Same as above.
>
> > +      (native-inputs
> > +       (list emacs-emms emacs-blight))
>
> I re-ordered inputs alphabetically.
>
> > +      (description
> > +       "@code{lemon} is a tiny system monitor which displays system 
> > information
> > +in the echo area when Emacs is has been idle for a few seconds.  This is a
> > +fork of zk_phi’s Symon, which has been largely rewritten.  It fixes a number 
> > of
> > +bugs and shortcomings and emphasizes customizability and code reuse, but also
> > +drops support for non-Linux platforms.  It works nicely with EXWM.")
>
> I removed the penultimate sentence, which is not useful in our case.
>
> Regards,
> -- 
> Nicolas Goaziou
>
>
> --- End Message ---