bug#70362: closed ([PATCH] Add font-locking for Go built-in functions in go-ts-mode)

[GNU bug Tracking System]

Your message dated Thu, 18 Apr 2024 13:31:25 +0300
with message-id <86wmovdksi.fsf@gnu.org>
and subject line Re: bug#70362: [PATCH] Add font-locking for Go built-in 
functions in go-ts-mode
has caused the debbugs.gnu.org bug report #70362,
regarding [PATCH] Add font-locking for Go built-in functions in go-ts-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
70362: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70362
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] Add font-locking for Go built-in functions in go-ts-mode Date: Fri, 12 Apr 2024 22:47:37 -0700

Tags: patch

This patch adds a new `builtin` feature to
`treesit-font-lock-feature-list` in `go-ts-mode` and a corresponding
rule to `go-ts-mode--font-lock-settings` to highlight Go's built-in functions.

0001-Add-font-locking-for-Go-built-in-functions-in-go-ts-.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#70362: [PATCH] Add font-locking for Go built-in functions in go-ts-mode
>
>
>
>
> Date: 
>
> Thu, 18 Apr 2024 13:31:25 +0300
>
>
>
>
> > From: Yuan Fu <casouri@gmail.com>
> > Date: Sun, 14 Apr 2024 16:32:43 -0700
> > Cc: Noah Peart <noah.v.peart@gmail.com>,
> >  Eli Zaretskii <eliz@gnu.org>,
> >  70362@debbugs.gnu.org
> > 
> > 
> > Dmitry Gutov <dmitry@gutov.dev> writes:
> > 
> > > On 13/04/2024 10:40, Noah Peart wrote:
> > >> I put it at level 3 following the conventions in other treesit modes
> > >> I checked: python-ts-mode, ruby-ts-mode, rust-ts-mode all put
> > >> builtins at level 3.
> > >> But, I haven't done a full census of the ts modes so there might be
> > >> variability.
> > >
> > > SGTM. If classic major modes highlight a thing (and they do that for
> > > built-ins), we usually put it in the default highlighting for ts modes
> > > as well (meaning level 3 or lower).
> > 
> > Right. And the patch looks good to me.
>
> Thanks, installed on master, and closing the bug.
>
>
> --- End Message ---