[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: another bug of find-file-noselect?

From: Gerd Moellmann
Subject: Re: another bug of find-file-noselect?
Date: Tue, 24 Oct 2000 16:53:36 +0200 (CEST)
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.0.90

Kenichi Handa <address@hidden> writes:

> Even if there are files temp.1, temp.2, temp.3, 
> (find-file-noselect "temp.*" t t t) returns the buffer for
> temp.1 only against this docstring:


> It seems that we can fix this bug just by removing the last
> `car' call in this code of find-file-noselect.
>     (if (and wildcards
>            find-file-wildcards
>            (not (string-match "\\`/:" filename))
>            (string-match "[[*?]" filename))
>       (let ((files (condition-case nil
>                        (file-expand-wildcards filename t)
>                      (error (list filename))))
>             (find-file-wildcards nil))
>         (if (null files)
>             (find-file-noselect filename)
>           (car (mapcar #'find-file-noselect files))))

I agree, that `car' looks bogus.

> But, it seems that the existence of `car' call is
> intentional.  In that case, docstring should be fixed.

I don't know why that `car' is there.  Maybe returning a list caused
some problem and a quick ``fix'' was to return a single buffer?

> Could someone tell which is wrong, the code or the
> docstring?  I myselft want to fix the code because otherwise
> we don't know which buffers are created by this function.

I also think the code is in error.

> By the way, Emacs Lisp Reference Manual says nothing special
> for the case that WILDCARDS is non-nil.   It just says:
>      The `find-file-noselect' function returns the buffer that is
>      visiting the file FILENAME.

Could you please add the missing bits?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]