Re: Fringes again

[Miles Bader]

Simon Josefsson <address@hidden> writes:
> I've now implemented one approach below.  It makes the user interface
> of fringe.el similar as mouse-avoidance-mode.el.  Is this OK?

I like that much better.

Perhaps `left' and `right' should be called `left-only' and `right-only'
to emphasize what they do (when I first looked at the choices, and saw
`left', I immediately thought `left what?' -- even though I already knew
what to expect!).

I also think it would be clearer to use `both' instead of `default',
but that would actually be a slight misnomer, since the implemenation
actually does just revert to the default, and that might make the name
wrong if the default is ever changed.  What do you think?

> It is consistent with how `toggle-scroll-bar' and `scroll-bar-mode'
> already behaves.  The docstring and the prompt triggered by invoking
> `toggle-fringe' and `fringe-mode' should now be clear.  Is this OK, or
> can you suggest alternative names?

Well, I like the prompting behavior better, and Richard approved the
name `toggle-fringe', but I'm not sure the name `toggle-fringe' makes
much sense if it doesn't actually `toggle'... :-(

One alternative would be to use the name `set-fringe-mode' to set the
per-frame fringe style -- this is also consistent with existing
practice, e.g., `set-default-font', `set-background-color', etc., and
with this name, prompting for a value actually make sense.  :-)

A last niggling point is that the (interactive ...) prompting code
should probably be put into a function, since it's duplicated in two
commands now...

Thanks,

-Miles

-- 
Come now, if we were really planning to harm you, would we be waiting here, 
 beside the path, in the very darkest part of the forest?