emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Updated patch for a Windows implementation of play-sound


From: Eli Zaretskii
Subject: Re: Updated patch for a Windows implementation of play-sound
Date: Wed, 23 Oct 2002 08:16:08 +0200 (IST)

On Wed, 23 Oct 2002, Stefan Monnier wrote:

> How about not adding a new file w32sound.c but instead adding the
> corresponding code to sound.c (and of course wrap things in
> #ifdef WINDOWSNT

Yes, I agree wholeheartedly.  Platform-specific source files are a pain; 
adding one more is something we should avoid IMHO.

sound.c is sufficiently small and already has lots of #ifdef's that test 
for specific systems, so adding another such portion won't change 
anything.

> (or _WIN32, I don't know what is what: most of
> the Emacs C code I've seen seems to be using WINDOWSNT)).

It's WINDOWSNT to avoid calling Windows ``a win'' ;-)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]