emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: |PATCH| describe-minor-mode and describe-minor-mode-from-indicator


From: Masatake YAMATO
Subject: Re: |PATCH| describe-minor-mode and describe-minor-mode-from-indicator
Date: Thu, 10 Apr 2003 17:36:14 +0900 (JST)

    It looks good.  You would need to merge it with the small changes
    that I made yesterday which were designed to make describe-minor-mode
    handle all the minor modes in minor-mode-alist.

    Meanwhile, I found that all the minor modes in minor-mode-alist
    is just a small subset of them.  It really ought to handle ALL
    minor modes.  Which means we need a new list which would be the
    list of all minor mode symbols.

    Making add-minor-mode build such a list would get most of the way there.
    So I will do that.  It's called minor-mode-list.

I think your change is nothing to do with indicator related functions
(describe-minor-mode-completion-table-for-indicator, 
 describe-minor-mode-from-indicator,
 lookup-minor-mode-from-indicator).

I changed describe-minor-mode-completion-table-for-symbol only.

(defun describe-minor-mode-completion-table-for-symbol ()
  ;; In order to list up all minor modes, minor-mode-list
  ;; is used here instead of minor-mode-alist.
  (delq nil (mapcar 
             (lambda (x) 
               (symbol-name x))
             minor-mode-list)))

If, Ok, I'll install to the CVS repository.

Masatake YAMATO




reply via email to

[Prev in Thread] Current Thread [Next in Thread]