[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 4 minor suggestions for files.el
From: |
Richard Stallman |
Subject: |
Re: 4 minor suggestions for files.el |
Date: |
Fri, 18 Apr 2003 07:28:59 -0400 |
Huh? It works just dandy here. The undo-log is correct (and has
the necessary entries corresponding to the insert-file operation).
The only real issue is not correctness but performance: the undo-log
might contain a very large string (if the insert-file operation had to
modify a large part of the buffer).
I think I understand now--it treats the insert-file operation as an
ordinary undoable buffer change.
Spiegel, is that really the right thing to do in VC?
I also worry about the large strings. Maybe there should be a file
size threshold on this change.
I was wondering if it would be worth it to try and make insert-file
even more clever: pass the `before' and `after' to diff and then apply
the diff by hand. This will preserve even more of the markers
(and would make the undo-log smaller and more useful, in the case
that revert-buffer doesn't flush it).
That is a very interesting idea. Perhaps diff could have an output
format designed to give the best possible results with Emacs, and
for the highest efficiency.
- 4 minor suggestions for files.el, Stefan Monnier, 2003/04/14
- Re: 4 minor suggestions for files.el, Kai Großjohann, 2003/04/15
- Re: 4 minor suggestions for files.el, Kevin Rodgers, 2003/04/15
- Re: 4 minor suggestions for files.el, Richard Stallman, 2003/04/16
- Re: 4 minor suggestions for files.el, Stefan Monnier, 2003/04/17
- Re: 4 minor suggestions for files.el,
Richard Stallman <=
- Re: 4 minor suggestions for files.el, Andre Spiegel, 2003/04/18
- Re: 4 minor suggestions for files.el, Stefan Monnier, 2003/04/18
- Re: 4 minor suggestions for files.el, Andre Spiegel, 2003/04/18
- Re: 4 minor suggestions for files.el, Stefan Monnier, 2003/04/18
- Re: 4 minor suggestions for files.el, Stefan Monnier, 2003/04/19
- Re: 4 minor suggestions for files.el, Richard Stallman, 2003/04/21
- Re: 4 minor suggestions for files.el, Richard Stallman, 2003/04/19
- Re: 4 minor suggestions for files.el, Stefan Monnier, 2003/04/29