Re: Suggestion: go to bottom of mail message

[Ehud Karni]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thu, 20 Nov 2003 23:08:48 -0500, Richard Stallman <address@hidden> wrote:
>
>           (rmail-beginning-of-message): Changed to position point to the
>           beginning of the BODY.
>
> I don't think I want that change.

Restored original behavior.

>           (rmail-beginning-of-message): Changed to position point to the
>           beginning of the BODY. (rmail-mode): change documentation.
>
> Be careful, this change log is not formatted right!

Fixed.



2003-11-21  Ehud Karni  <address@hidden>

        * mail/rmailsum.el (rmail-summary-end-of-message): New command
        to go to the bottom of the mail message. Added to
        `rmail-summary-mode-map' with key "/".
        (rmail-summary-show-message) New (internal) function for use by
        both `rmail-summary-beginning/end-of-message'.
        (rmail-summary-beginning-of-message) Changed to use the new
        function.

        * mail/rmail.el (rmail-end-of-message): New command to go to the
        end of the current message. Added to `rmail-mode-map' with key "/".
        (rmail-beginning-of-message): Fixed a minor bug, disregard
        positioning by `rmail-show-message-hook'.
        (rmail-mode): `rmail-end-of-message' added to the documentation


diff -c /lnx1/gnu/src/emacs/lisp/mail/rmailsum.el.\~1.131.\~ 
/lnx1/gnu/src/emacs/lisp/mail/rmailsum.el
*** /lnx1/gnu/src/emacs/lisp/mail/rmailsum.el.~1.131.~  Wed Nov 19 12:48:01 2003
- --- /lnx1/gnu/src/emacs/lisp/mail/rmailsum.el Fri Nov 21 08:51:50 2003
***************
*** 890,895 ****
- --- 890,896 ----
    (define-key rmail-summary-mode-map "x"      'rmail-summary-expunge)
    (define-key rmail-summary-mode-map "w"      'rmail-summary-output-body)
    (define-key rmail-summary-mode-map "."      
'rmail-summary-beginning-of-message)
+   (define-key rmail-summary-mode-map "/"      'rmail-summary-end-of-message)
    (define-key rmail-summary-mode-map "<"      'rmail-summary-first-message)
    (define-key rmail-summary-mode-map ">"      'rmail-summary-last-message)
    (define-key rmail-summary-mode-map " "      'rmail-summary-scroll-msg-up)
***************
*** 1180,1185 ****
- --- 1181,1196 ----
  (defun rmail-summary-beginning-of-message ()
    "Show current message from the beginning."
    (interactive)
+   (rmail-summary-show-message 'BEG))
+
+ (defun rmail-summary-end-of-message ()
+   "Show bottom of current message."
+   (interactive)
+   (rmail-summary-show-message 'END))
+
+ (defun rmail-summary-show-message (where)
+   "Show current mail message.
+ Position it according to WHERE which can be BEG or END"
    (if (and (one-window-p) (not pop-up-frames))
        ;; If there is just one window, put the summary on the top.
        (let ((buffer rmail-view-buffer))
***************
*** 1191,1197 ****
        (or (eq buffer (window-buffer (next-window (frame-first-window))))
            (delete-other-windows)))
      (pop-to-buffer rmail-view-buffer))
!   (beginning-of-buffer)
    (pop-to-buffer rmail-summary-buffer))

  (defun rmail-summary-bury ()
- --- 1202,1214 ----
        (or (eq buffer (window-buffer (next-window (frame-first-window))))
            (delete-other-windows)))
      (pop-to-buffer rmail-view-buffer))
!   (cond
!    ((eq where 'BEG)
!       (goto-char (point-min)))
!    ((eq where 'END)
!       (goto-char (point-max))
!       (recenter (1- (window-height))))
!    )
    (pop-to-buffer rmail-summary-buffer))

  (defun rmail-summary-bury ()

Diff finished at Fri Nov 21 09:08:03


diff -c /lnx1/gnu/src/emacs/lisp/mail/rmail.el.\~1.376.\~ 
/lnx1/gnu/src/emacs/lisp/mail/rmail.el
*** /lnx1/gnu/src/emacs/lisp/mail/rmail.el.~1.376.~     Wed Nov 19 12:48:00 2003
- --- /lnx1/gnu/src/emacs/lisp/mail/rmail.el    Fri Nov 21 09:00:12 2003
***************
*** 848,853 ****
- --- 848,854 ----
    (define-key rmail-mode-map "w"      'rmail-output-body-to-file)
    (define-key rmail-mode-map "x"      'rmail-expunge)
    (define-key rmail-mode-map "."      'rmail-beginning-of-message)
+   (define-key rmail-mode-map "/"      'rmail-end-of-message)
    (define-key rmail-mode-map "<"      'rmail-first-message)
    (define-key rmail-mode-map ">"      'rmail-last-message)
    (define-key rmail-mode-map " "      'scroll-up)
***************
*** 993,998 ****
- --- 994,1000 ----
  Instead, these commands are available:

  \\[rmail-beginning-of-message]        Move point to front of this message 
(same as \\[beginning-of-buffer]).
+ \\[rmail-end-of-message]      Move point to bottom of this message.
  \\[scroll-up] Scroll to next screen of this message.
  \\[scroll-down]       Scroll to previous screen of this message.
  \\[rmail-next-undeleted-message]      Move to Next non-deleted message.
***************
*** 2427,2433 ****
  (defun rmail-beginning-of-message ()
    "Show current message starting from the beginning."
    (interactive)
!   (rmail-show-message rmail-current-message))

  (defun rmail-show-message (&optional n no-summary)
    "Show message number N (prefix argument), counting from start of file.
- --- 2429,2449 ----
  (defun rmail-beginning-of-message ()
    "Show current message starting from the beginning."
    (interactive)
!   (let ((rmail-show-message-hook
!        (append rmail-show-message-hook
!              (list (function (lambda ()
!                                (goto-char (point-min))))))))
!     (rmail-show-message rmail-current-message)))
!
! (defun rmail-end-of-message ()
!   "Show bottom of current message."
!   (interactive)
!   (let ((rmail-show-message-hook
!        (append rmail-show-message-hook
!              (list (function (lambda ()
!                                (goto-char (point-max))
!                                (recenter (1- (window-height)))))))))
!   (rmail-show-message rmail-current-message)))

  (defun rmail-show-message (&optional n no-summary)
    "Show message number N (prefix argument), counting from start of file.

Diff finished at Fri Nov 21 09:09:12


- --
 Ehud Karni           Tel: +972-3-7966-561  /"\
 Mivtach - Simon      Fax: +972-3-7966-667  \ /  ASCII Ribbon Campaign
 Insurance agencies   (USA) voice mail and   X   Against   HTML   Mail
 http://www.mvs.co.il  FAX:  1-815-5509341  / \
 GnuPG: 98EA398D <http://www.keyserver.net/>    Better Safe Than Sorry
-----BEGIN PGP SIGNATURE-----
Comment: use http://www.keyserver.net/ to get my key (and others)

iD8DBQE/vbv1LFvTvpjqOY0RAt54AJ0TbeDMc5FL+gjlKEXXkdZNyl/1RwCdEEGj
0chb3qO2whhUDXJ4ZlZ1PBw=
=Yv96
-----END PGP SIGNATURE-----