Re: [patch] add interactive browse of revisions from vc *Annotate* buffers

[Benjamin Rutt]

Stefan Monnier <address@hidden> writes:

> I strongly expect that the problem is in the fact that you use view-mode as
> parent even though it's not a major-mode.

Thanks for the tip, you are correct; I guess define-derived-mode was
somewhat misleading to me since it doesn't mention anywhere in 'C-h f
define-derived-mode' that it only works for major modes.

Andre, could you install the following tiny patch that fixes the
problem?

Index: lisp/vc.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/vc.el,v
retrieving revision 1.362
diff -u -r1.362 vc.el
--- lisp/vc.el  20 Jan 2004 17:39:09 -0000      1.362
+++ lisp/vc.el  20 Jan 2004 22:25:47 -0000
@@ -2830,7 +2830,7 @@
 `vc-annotate-buffers'."
   (cdr (assoc buffer vc-annotate-buffers)))
 
-(define-derived-mode vc-annotate-mode view-mode "Annotate"
+(define-derived-mode vc-annotate-mode fundamental-mode "Annotate"
   "Major mode for output buffers of the `vc-annotate' command.
 
 You can use the mode-specific menu to alter the time-span of the used
@@ -2839,6 +2839,7 @@
   (set (make-local-variable 'truncate-lines) t)
   (set (make-local-variable 'font-lock-defaults)
        '(vc-annotate-font-lock-keywords t))
+  (view-mode 1)
   (vc-annotate-add-menu))
 
 (defun vc-annotate-display-default (&optional ratio)

-- 
Benjamin