[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Delayed loading of image libraries
From: |
Andreas Schwab |
Subject: |
Re: [PATCH] Delayed loading of image libraries |
Date: |
Wed, 30 Jun 2004 13:24:18 +0200 |
User-agent: |
Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) |
Juanma Barranquero <address@hidden> writes:
> On Wed, 30 Jun 2004 12:15:29 +0200
> Andreas Schwab <address@hidden> wrote:
>
>> Please make libraries an explicit parameter of CHECK_LIB_AVAILABLE, so
>> that it does not look like it is completely ignored.
>
> Well, it is a matter of taste. Hidding things is not good, but
> redundant info is not good either, and in this case, there's no way
> CHECK_LIB_AVAILABLE is ever gonna get passed anything but `libraries'.
Implicit parameters are bad when you want to find out what's going on and
can hide hard to track bugs.
On a related note, what is Finit_image_library supposed to be passed in
lookup_image_type? image-library-alist is not available on the C level.
Andreas.
--
Andreas Schwab, SuSE Labs, address@hidden
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."