emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Another bug with the macro counter


From: Stefan
Subject: Re: Another bug with the macro counter
Date: Sat, 30 Oct 2004 00:06:11 -0400
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/21.3.50 (darwin)

> ***************
> *** 865,873 ****
>     (if (and (integerp value)
>              (or (not (memq this-command '(eval-last-sexp 
> eval-print-last-sexp)))
>                  (eq this-command last-command)
> !                (and (boundp 'edebug-active) edebug-active)))
>         (let ((char-string
> !              (if (or (and (boundp 'edebug-active) edebug-active)
>                        (memq this-command '(eval-last-sexp 
> eval-print-last-sexp)))
>                    (prin1-char value))))
>           (if char-string
> --- 865,874 ----
>     (if (and (integerp value)
>              (or (not (memq this-command '(eval-last-sexp 
> eval-print-last-sexp)))
>                  (eq this-command last-command)
> !                (and (boundp 'edebug-active) (with-no-warnings 
> edebug-active))))
>         (let ((char-string
> !              (if (or (and (boundp 'edebug-active)
> !                       (with-no-warnings edebug-active))
>                        (memq this-command '(eval-last-sexp 
> eval-print-last-sexp)))
>                    (prin1-char value))))
>           (if char-string

I believe replacing (and (boundp 'foo) foo) with (if (boundp 'foo) foo)
is a better choice because it removes the warning wihtout cluttering the
code and without introducing compatibility problems with older Emacsen.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]