RE: isearch highlighting

[klaus.berndl]

Stefan Monnier wrote:
>> I think it is safe to put the body of `isearch-lazy-highlight-update'
>> in the `with-local-quit' block, because quit in this function can't
>> lead to a corrupted state.
> 
> Agreed.  I'd even put it in `while-no-input'.  You might want to add

OT: you mention `while-no-input' whic remembers me to a discussion about this.
is this macro now available or have i misunderstood here something??

Klaus

> the patch below, tho, just so the code can't be interrupted after
> placing the new overlay but before it's recorded on the list.  There
> might be other similar issues, I haven't checked.
> 
>> It seems this change is unrelated to the
>> proposed solution of a new form of really hard C-g (which is useful
>> to interrupt the code which can put the process in a corrupted
>> state). 
> 
> Of course.  The idea of a "really hard C-g" is to work around
> problems, 
> but it should not be an excuse to not fix those problems.
> 
>> because most regexp in Emacs packages are well tested and contains no
>> nested repetitions.
> 
> Is that an attempt at humor?
> 
> 
>         Stefan
> 
> 
> --- orig/lisp/isearch.el
> +++ mod/lisp/isearch.el
> @@ -2480,10 +2480,10 @@
> 
>                      ;; non-zero-length match
>                      (let ((ov (make-overlay mb me)))
> +                      (push ov isearch-lazy-highlight-overlays)
>                        (overlay-put ov 'face
>                        isearch-lazy-highlight-face) (overlay-put ov
> 'priority 0) ;lower than main overlay 
> -                      (overlay-put ov 'window (selected-window))
> -                      (push ov isearch-lazy-highlight-overlays)))
> +                      (overlay-put ov 'window (selected-window))))
>                    (if isearch-forward
>                        (setq isearch-lazy-highlight-end (point))
>                      (setq isearch-lazy-highlight-start (point)))))
> 
> 
> _______________________________________________
> Emacs-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/emacs-devel