Re: [PATCH] make-dist fixes and clean-ups

[Lute Kamstra]

Jérôme Marant <address@hidden> writes:

> Lute Kamstra <address@hidden> writes:
>
>> So you do the following?
>>
>>   1. Checkout a clean working copy of Emacs' CSV.
>>   2. Run "make-dist --snapshot" to get a tarball (without .elc or info
>>      files). 
>>   3. Unpack this tarball.
>>   4. Run ".configure" and "make bootstrap" on that tree.
>
> Exactly.
>
>> What about the patch below then?  It makes sure that make-dist never
>> distributes ldefs-boot.el (that way, ldefs-boot.el will never be
>> installed either) and it ensures that a tarball created by the above
>> method can bootstrap.
>
> Many people already proposed that

Huh?  I didn't see it in any of the messages posted to emacs-devel.
They all talked about changing Emacs' Makefiles or the Debian script,
not about changing make-dist.

> but this is wrong since 'make maintainer-clean', which undoes the
> bootstrap, will remove loaddefs.el (which is fine since
> autogenerated files have to be removed).
>
> Hence, I can't bootstrap more than once with the same tarball.

Out of curiosity: do you have any special reason to do a "make
maintainer-clean" before a second "make bootstrap"?  Why do a second
bootstrap at all?

> How about leaving ldefs-boot.el and see if it hurts?

Apart from being redundant under normal circumstances, it probably
doesn't hurt in any way.  Come to think of it: it's actually a nice
feature that the distribution tarball allows a "make maintainer-clean"
and then a ".configure" plus "make bootstrap".

You convinced me to distribute ldefs-boot.el.  ;-)

Lute.