emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Options menu is broken on CVS


From: Eli Zaretskii
Subject: Re: Options menu is broken on CVS
Date: Wed, 07 Sep 2005 07:16:31 +0300

> From: Nick Roberts <address@hidden>
> Date: Wed, 7 Sep 2005 11:01:27 +1200
> Cc: address@hidden
> 
> It seems to be due to this change:
> 
> 2004-03-13  Eli Zaretskii  <address@hidden>
> 
>       * emacs.c (main): Call syms_of_xmenu only if HAVE_MENUS is defined.
> 
> I guess it hasn't been noticed before because, although people may use tmm,
> most use a version of Emacs thats compiled with X (or at least HAVE_MENUS).
> 
> I haven't reverted this change because it must be there for a reason.  Eli?

It _was_ for a reason.  The 2 related changes I committed at that time
were these:

2004-03-13  Eli Zaretskii  <address@hidden>

        * Makefile.in (XMENU_OBJ): Include xmenu.o if HAVE_MENUS is defined.

        * emacs.c (main): Call syms_of_xmenu only if HAVE_MENUS is defined.

I don't remember the details (you will probably find them in
emacs-devel or emacs-pretest-bug archives for that period of time),
but there was some build failure, I think on MacOS, which these
changes were part of fixing.

Please don't take out this change without understanding what it was
fixing in the first place.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]