Re: tool bar icons not updated according to :active condition

[Reiner Steib]

On Mon, Feb 27 2006, Richard Stallman wrote:

>     The following gives better results (but of course it is still a
>     workaround, not a fix).
>
> What is the underlying bug, for which this is a workaround?

The tool bar icons are not updated according to the :active condition.
I'm including the original report below.

You did already sent two reminder to emacs-devel, and added it to
admin/FOR-RELEASE:

,----[ admin/FOR-RELEASE ]
| * BUGS
| 
| ** Reiner Steib's 23 Jan 2006 bug report that tool bar icons don't update.
| URL/MID: http://mid.gmane.org/address@hidden
`----

(I have added the URL/MID there.)

Bye, Reiner

My original report was:

--8<---------------cut here---------------start------------->8---
From: Reiner Steib <address@hidden>
Subject: tool bar icons not updated according to :active condition
Date: Mon, 23 Jan 2006 19:59:13 +0100
Message-ID: <address@hidden>
Reply-To: Reiner Steib <address@hidden>
To: address@hidden

  (easy-menu-define gnus-group-reading-menu gnus-group-mode-map ""
    `("Group"
      [...]
      ["Describe" gnus-group-describe-group
        :active (gnus-group-group-name) ...]

I.e. this menu item should be inactive[1] if the point isn't on a
group line (e.g. on non-group lines when using topics mode [2]).  In
the menu, this works correctly, i.e. the menu item is disabled
(probably because the menu is updated when clicking on "Group").

In `gnus-group-make-tool-bar' the describe-group entry is also added
to the tool bar (icon: etc/images/gnus/describe-group.xpm):

  (tool-bar-add-item-from-menu
    'gnus-group-describe-group "describe-group" gnus-group-mode-map)

But after moving up/down in the group buffer (C-p/C-n), the icon is
not updated (enabled/disabled) when changing from a group to a topic
line and vice versa.

After `C-l' (or after `redraw-frame' [3]), the correct icon is
displayed.  A workaround could be to redraw the frame after every
point-motion (is there a after-point-motion-hook?).

Bye, Reiner.

[1]
,----[ <f1> f gnus-group-group-name RET ]
| gnus-group-group-name is a compiled Lisp function in `gnus-group.el'.
| (gnus-group-group-name)
| 
| Get the name of the newsgroup on the current line.
`----

[2]
,----
| [ Gnus -- 6456 ]
|   [ misc -- 11 ]
|          1: nnml:test 
|         10: nndraft:drafts 
| [...]
`----

[3] Tested with...

(global-set-key (kbd "<down>")
                (lambda (&optional arg)
                  (interactive)
                  (or arg (setq arg 1))
                  (next-line arg)
                  (redraw-frame (selected-frame))))
--8<---------------cut here---------------end--------------->8---